From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: src/test/ssl/t/001_ssltests.pl should not tromp on file
 permissions
In-reply-to: 
 <CAB7nPqROCeCMzLBiRCMkc_V=JjN=RVM+0F-zmCM3g6QrMhhPsQ@mail.gmail.com>
References: <14836.1494885946@sss.pgh.pa.us>
 <CAB7nPqROCeCMzLBiRCMkc_V=JjN=RVM+0F-zmCM3g6QrMhhPsQ@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Tue, 16 May 2017 11:18:02 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23036.1494905363.1@sss.pgh.pa.us>
Date: Mon, 15 May 2017 23:29:23 -0400
Message-ID: <23037.1494905363@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> On Tue, May 16, 2017 at 7:05 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We could maybe make 001_ssltests.pl save and restore the file's
>> permissions, but I think probably a cleaner answer is to have it
>> make a temporary copy and set the permissions on that.

> Ah, you are talking about ss/client.key here... Using a temporary copy
> makes the most sense to me, as there is no need to think about putting
> back the old permissions on test failure, and the original tree
> remains unmodified all the time.

Pushed with minor adjustments --- I made the test script unlink the temp
file at the end, and tightened the .gitignore patterns a bit.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers