Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owCHp-0008Bh-25 for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2022 01:04:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1owCHn-0000I8-Tp for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Nov 2022 01:04:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owCHn-0000Ha-Kf for pgsql-hackers@lists.postgresql.org; Sat, 19 Nov 2022 01:04:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owCHk-0008IO-IE for pgsql-hackers@lists.postgresql.org; Sat, 19 Nov 2022 01:04:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2AJ14eRT2304166; Fri, 18 Nov 2022 20:04:40 -0500 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org, Tomas Vondra Subject: Re: test/modules/test_oat_hooks vs. debug_discard_caches=1 In-reply-to: <20221119003349.uzpopxq2skgrmwc4@awork3.anarazel.de> References: <2267406.1668804934@sss.pgh.pa.us> <20221119003349.uzpopxq2skgrmwc4@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 18 Nov 2022 16:33:49 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2304164.1668819880.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 18 Nov 2022 20:04:40 -0500 Message-ID: <2304165.1668819880@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-11-18 15:55:34 -0500, Tom Lane wrote: >> The test_oat_hooks test is failing --- it's not crashing, but >> it's emitting more NOTICE lines than the expected output includes, >> evidently as a result of the hooks getting invoked extra times >> during cache reloads. I can reproduce that here. > Did you already look into where those additional namespace searches are = coming > from? There are case in which it is not unproblematic to have repeated > namespace searches due to the potential for races it opens up... I'm not sufficiently interested in that API to dig hard for details, but in a first look it seemed like the extra reports were coming from repeated executions of recomputeNamespacePath, which are forced after a cache invalidation by NamespaceCallback. regards, tom lane