From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
cc: Julien Rouhaud <rjuju123@gmail.com>,
        =?UTF-8?Q?Darafei_Kom=D1=8Fpa_Praliaskouski?= <me@komzpa.net>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Marking some contrib modules as trusted extensions
In-reply-to: 
 <CAEZATCXeVkFfytGYxuF1Th-5-dPEoDuOrx-7Tc_rjfJ8XLWAbw@mail.gmail.com>
References: <32315.1580326876@sss.pgh.pa.us>
 <CAC8Q8tKiedws=GNF_M50tV7qw7TJ0y_=+k+WJHPNc=VqScZr5A@mail.gmail.com>
 <CAOBaU_YcmiKnLvb8kpLNA59Di9WA02V3_TCfJ8pAMriPfeRq_w@mail.gmail.com>
 <5280.1580333933@sss.pgh.pa.us>
 <CAEZATCXeVkFfytGYxuF1Th-5-dPEoDuOrx-7Tc_rjfJ8XLWAbw@mail.gmail.com>
Comments: In-reply-to Dean Rasheed <dean.a.rasheed@gmail.com>
	message dated "Fri, 31 Jan 2020 09:40:32 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23116.1580483599.1@sss.pgh.pa.us>
Date: Fri, 31 Jan 2020 10:13:19 -0500
Message-ID: <23117.1580483599@sss.pgh.pa.us>
Precedence: bulk

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Wed, 29 Jan 2020 at 21:39, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The bigger picture here is that I don't want to get push-back that
>> we've broken somebody's security posture by marking too many extensions
>> trusted.  So for anything where there's any question about security
>> implications, we should err in the conservative direction of leaving
>> it untrusted.

> I wonder if the same could be said about pgrowlocks.

Good point.  I had figured it was probably OK given that it's
analogous to the pg_locks view (which is unrestricted AFAIR),
and that it already has some restrictions on what you can see.
I'd have no hesitation about dropping it off this list though,
since it's probably not used that much and it could also be seen
as exposing internals.

			regards, tom lane