Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poDkd-0002E1-SI for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 01:33:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1poDkc-0001UI-JX for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 01:33:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poDkc-0001U8-9v for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 01:33:50 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1poDkZ-000Eb3-Sm; Mon, 17 Apr 2023 01:33:49 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 33H1XhiO2313470; Sun, 16 Apr 2023 21:33:43 -0400 From: Tom Lane To: Stephen Frost cc: "Jonathan S. Katz" , Thomas Munro , pgsql-hackers@lists.postgresql.org, Amit Kapila , Alvaro Herrera Subject: Re: longfin missing gssapi_ext.h In-reply-to: References: <4080250.1681141040@sss.pgh.pa.us> <763952.1681272015@sss.pgh.pa.us> <1123190.1681314906@sss.pgh.pa.us> <1ed077e4-a831-b0b6-7298-0238cf6b0c08@postgresql.org> Comments: In-reply-to Stephen Frost message dated "Thu, 13 Apr 2023 08:58:59 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2313468.1681695223.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 16 Apr 2023 21:33:43 -0400 Message-ID: <2313469.1681695223@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Stephen Frost writes: > Pushed, thanks again to everyone. > I'll monitor the buildfarm and assuming there isn't anything unexpected > then I'll mark the open item as resolved now. The Debian 7 (Wheezy) members of the buildfarm (lapwing, skate, snapper) are all getting past the gssapi_ext.h check you added and then failing like this: ccache gcc -std=3Dgnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdecla= ration-after-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attri= bute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=3Ds= tandard -g -O2 -Werror -I../../../src/include -DENFORCE_REGRESSION_TEST_N= AME_RESTRICTIONS -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include/et = -c -o be-gssapi-common.o be-gssapi-common.c be-gssapi-common.c: In function 'pg_store_delegated_credential': be-gssapi-common.c:110:2: error: unknown type name 'gss_key_value_element_= desc' be-gssapi-common.c:111:2: error: unknown type name 'gss_key_value_set_desc= ' be-gssapi-common.c:113:4: error: request for member 'key' in something not= a structure or union be-gssapi-common.c:114:4: error: request for member 'value' in something n= ot a structure or union be-gssapi-common.c:115:7: error: request for member 'count' in something n= ot a structure or union be-gssapi-common.c:116:7: error: request for member 'elements' in somethin= g not a structure or union be-gssapi-common.c:119:2: error: implicit declaration of function 'gss_sto= re_cred_into' [-Werror=3Dimplicit-function-declaration] Debian 7 has been EOL five years or so, so I don't mind saying "get a newer OS or disable gssapi". However, is it worth adding another configure check to fail a little faster with whatever Kerberos version this is? Checking that gss_store_cred_into() exists seems like the most obvious one of these things to test for. regards, tom lane