Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ls70Q-0003Ls-5F
	for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Jun 2021 17:01:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ls70M-0004s7-AA
	for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Jun 2021 17:01:06 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ls70M-0004rw-2a
	for pgsql-hackers@lists.postgresql.org; Sat, 12 Jun 2021 17:01:06 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ls70K-0005fy-Bn
	for pgsql-hackers@lists.postgresql.org; Sat, 12 Jun 2021 17:01:05 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15CH12lL2322000;
	Sat, 12 Jun 2021 13:01:02 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
cc: Mark Dilger <mark.dilger@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Simon Riggs <simon.riggs@enterprisedb.com>
Subject: Re: logical replication of truncate command with trigger causes
 Assert
In-reply-to: 
 <CAA4eK1KkSpzioy4RwuiyQb_CrQ2URHSPShHTAEPswr25gX0r9g@mail.gmail.com>
References: <B4A3AF82-79ED-4F4C-A4E5-CD2622098972@enterprisedb.com>
 <1250962.1623192946@sss.pgh.pa.us>
 <CBED95D4-5072-4A16-9271-72AB73478817@enterprisedb.com>
 <1254157.1623196736@sss.pgh.pa.us>
 <CAA4eK1+DgDdrcxQkB7s-_PmReJB7HiaFrU2PyCzqGStOwiCVPA@mail.gmail.com>
 <1356183.1623250358@sss.pgh.pa.us>
 <C6BE98EB-158D-4130-9E1C-C3DCFAE0A023@enterprisedb.com>
 <CAA4eK1L_Bw_itqBxCBW26z5SD6ru_gNWO1Xa1CTG3Jzog0sGxg@mail.gmail.com>
 <1719083.1623351052@sss.pgh.pa.us>
 <CAA4eK1+n=4pQXKVDMO6QG7kL2QUxgeV2cq3m8_CNd_Q3Vu73iA@mail.gmail.com>
 <1882577.1623425201@sss.pgh.pa.us>
 <CAA4eK1KkSpzioy4RwuiyQb_CrQ2URHSPShHTAEPswr25gX0r9g@mail.gmail.com>
Comments: In-reply-to Amit Kapila <amit.kapila16@gmail.com>
	message dated "Sat, 12 Jun 2021 12:45:28 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2321998.1623517262.1@sss.pgh.pa.us>
Date: Sat, 12 Jun 2021 13:01:02 -0400
Message-ID: <2321999.1623517262@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/2321999.1623517262%40sss.pgh.pa.us>
Precedence: bulk

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Fri, Jun 11, 2021 at 8:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I was thinking maybe we could mark all these replication protocol
>> violation errors non-translatable.  While we don't want to crash on a
>> protocol violation, it shouldn't really be a user-facing case either.

> I don't see any problem with that as these are not directly related to
> any user operation. So, +1 for making these non-translatable.

Done that way.  On re-reading the code, there were a bunch more
Asserts that could be triggered by bad input data, so the committed
patch has rather more corrections than I posted before.

			regards, tom lane