Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tYsgZ-00GCl0-5C
	for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Jan 2025 20:11:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tYsgW-005R6K-V1
	for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Jan 2025 20:11:17 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tYsgW-005R3P-Kl
	for pgsql-hackers@lists.postgresql.org; Fri, 17 Jan 2025 20:11:17 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tYsgT-00051f-3C
	for pgsql-hackers@lists.postgresql.org;
	Fri, 17 Jan 2025 20:11:16 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 50HKBAok2328260;
	Fri, 17 Jan 2025 15:11:10 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Treat <rob@xzilla.net>
cc: Shinya Kato <Shinya11.Kato@oss.nttdata.com>,
        Yugo Nagata <nagata@sraoss.co.jp>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Set AUTOCOMMIT to on in script output by pg_dump
In-reply-to: <CABV9wwM4vzO2BYDgw0N9Yd6TTrmrvT+eLrSfWE2z7Ra3CQtdXA@mail.gmail.com>
References: <96ff23a5d858ff72ca8e823a014d16fe@oss.nttdata.com> <20241009120314.118a641fa25148c3d564a6ae@sraoss.co.jp> <CAKFQuwbnNfH0RYcDnwYkhbXi_VK+yKHaMGvRP9J1vFrLHnze0w@mail.gmail.com> <2351827.1728447022@sss.pgh.pa.us> <CAKFQuwZ8H9erEpDXO=ucgSLbMJfutZf+d=WQXWoJiB2ziD_Xpg@mail.gmail.com> <20241009151508.eb37141e5ad29d0ca1e44eb9@sraoss.co.jp> <18f52adc395bece3c9d4373890560bbd@oss.nttdata.com> <CABV9wwM4vzO2BYDgw0N9Yd6TTrmrvT+eLrSfWE2z7Ra3CQtdXA@mail.gmail.com>
Comments: In-reply-to Robert Treat <rob@xzilla.net>
	message dated "Fri, 17 Jan 2025 10:45:46 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2328258.1737144670.1@sss.pgh.pa.us>
Date: Fri, 17 Jan 2025 15:11:10 -0500
Message-ID: <2328259.1737144670@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2328259.1737144670%40sss.pgh.pa.us>
Precedence: bulk

Robert Treat <rob@xzilla.net> writes:
> suggested diffs attached, let me know if you would like a consolidated patch

Sadly, the cfbot is now confused since it doesn't understand the idea
of an incremental patch.  Somebody please post a consolidated patch.

For myself, I'd suggest writing the examples with -X not --no-psqlrc.
-X is shorter, it's more likely to be what people would actually
type, and it's not jarringly inconsistent with the adjacent use
of -h and other short-form switches.  We can write the added
paragraphs like 

   It is generally recommended to use the <option>-X</option>
   (<option>--no-psqlrc</option>) option when restoring a database ...

to provide clarity about what the switch does.

			regards, tom lane