From: Tom Lane <tgl@sss.pgh.pa.us>
To: Piotr Stefaniak <postgres@piotr-stefaniak.me>
cc: Bruce Momjian <bruce@momjian.us>, Andres Freund <andres@anarazel.de>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "Stephen
 Frost" <sfrost@snowman.net>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Preliminary results for proposed new pgindent implementation
In-reply-to: 
 <VI1PR03MB11990AE83B88CAD06756A27BF2C10@VI1PR03MB1199.eurprd03.prod.outlook.com>
References: <20170519173111.zp6igkcg53egdy4s@alvherre.pgsql>
 <cb9eebd2-0214-1f34-51af-ebb69ec8a711@2ndquadrant.com>
 <29275.1497624664@sss.pgh.pa.us> <8827.1497633050@sss.pgh.pa.us>
 <20170616171946.qqy5tapovsamkxyg@alap3.anarazel.de>
 <9900.1497634441@sss.pgh.pa.us>
 <20170616180534.cdpduuq5a4twxuru@alap3.anarazel.de>
 <12302.1497637380@sss.pgh.pa.us> <20170616184238.GA5081@momjian.us>
 <20170616185406.jpwq6o6ghpvprxmi@alap3.anarazel.de>
 <20170616190441.GB5081@momjian.us> <29590.1497643007@sss.pgh.pa.us>
 <VI1PR03MB1199CEA13AEFE46308D9F7F5F2C10@VI1PR03MB1199.eurprd03.prod.outlook.com>
 <12517.1497650535@sss.pgh.pa.us>
 <VI1PR03MB11990AE83B88CAD06756A27BF2C10@VI1PR03MB1199.eurprd03.prod.outlook.com>
Comments: In-reply-to Piotr Stefaniak <postgres@piotr-stefaniak.me>
	message dated "Fri, 16 Jun 2017 22:52:53 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23381.1497665887.1@sss.pgh.pa.us>
Date: Fri, 16 Jun 2017 22:18:07 -0400
Message-ID: <23382.1497665887@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Piotr Stefaniak <postgres@piotr-stefaniak.me> writes:
> On 2017-06-17 00:02, Tom Lane wrote:
>> What I'm testing with right now has just four differences from your repo:

> There are also the "portability fixes" and they're the main problem.

Fair enough.

> I've simply removed things like capsicum or __FBSDID() because I thought
> it wouldn't be a problem since Postgres will have its own copy of indent
> anyway (so that its behavior is not a moving target). I can ifdef-out
> them instead of removing entirely, I just didn't think it was important
> anymore.

We should be able to deal with those via some #define hackery, no?

> I expect to be in trouble for replacing err() and errx(), though.

Understood.  I think we could deal with this by providing err() and
errx() in a support file that would be part of our distribution but
not yours.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers