Message-ID: <233e19c9-6819-ca0f-5314-f5f9285ac874@dunslane.net>
Date: Mon, 13 Dec 2021 10:05:35 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: daitch_mokotoff module
Content-Language: en-US
To: Tomas Vondra <tomas.vondra@enterprisedb.com>, Dag Lem <dag@nimrod.no>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <yger1atbgfy.fsf@sid.nimrod.no> <ygek0g87hgx.fsf@sid.nimrod.no>
 <0cac2d60-5b85-59c6-1ac1-77092b8688b7@enterprisedb.com>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <0cac2d60-5b85-59c6-1ac1-77092b8688b7@enterprisedb.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/233e19c9-6819-ca0f-5314-f5f9285ac874%40dunslane.net>
Precedence: bulk


On 12/13/21 09:26, Tomas Vondra wrote:
> On 12/13/21 14:38, Dag Lem wrote:
>> Please find attached an updated patch, with the following fixes:
>>
>> * Replaced remaining malloc/free with palloc/pfree.
>> * Made "make check" pass.
>> * Updated notes on other implementations.
>>
>
> Thanks, looks interesting. A couple generic comments, based on a quick
> code review.
>
> 1) Can the extension be marked as trusted, just like fuzzystrmatch?
>
> 2) The docs really need an explanation of what the extension is for,
> not just a link to fuzzystrmatch. Also, a couple examples would be
> helpful, I guess - similarly to fuzzystrmatch. The last line in the
> docs is annoyingly long.


It's not clear to me why we need a new module for this. Wouldn't it be
better just to add the new function to fuzzystrmatch?


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com