Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciT4M-0005Zu-SD for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2017 21:42:58 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ciT4M-0000tw-5R for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Feb 2017 21:42:58 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ciT2r-0006iF-2I for pgsql-hackers@postgresql.org; Mon, 27 Feb 2017 21:41:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ciT2k-00034w-GN for pgsql-hackers@postgresql.org; Mon, 27 Feb 2017 21:41:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v1RLfF4K023418; Mon, 27 Feb 2017 16:41:15 -0500 From: Tom Lane To: Andrew Dunstan cc: PostgreSQL-development Subject: Re: btree_gin and btree_gist for enums In-reply-to: <1c283f8e-7f26-d2e9-7860-7c4a38390051@2ndQuadrant.com> References: <56EA8A71.8060107@dunslane.net> <03f7d748-0f89-e8e1-094d-f04e1026b93d@dunslane.net> <27220.1478360811@sss.pgh.pa.us> <31412.1478366009@sss.pgh.pa.us> <60fb708c-8b3c-1337-934e-c1bfe2afc539@dunslane.net> <8258.1487886101@sss.pgh.pa.us> <4376a7bf-ab8c-e640-9021-94b148f9d733@2ndQuadrant.com> <6704.1487952174@sss.pgh.pa.us> <930cb563-6dc6-c4af-3be9-31f06c60361e@2ndQuadrant.com> <8a8c60b4-39c0-69a4-824c-e364f5fd97ea@2ndQuadrant.com> <12734.1488042261@sss.pgh.pa.us> <4e730f28-742b-45e9-d507-4d292fbd7834@2ndQuadrant.com> <22791.1488047671@sss.pgh.pa.us> <8a9a7d1a-54e4-4d76-ddd6-f5a8f1829de3@2ndQuadrant.com> <19852.1488140777@sss.pgh.pa.us> <88f65d25-8c32-1e09-f1ad-7f10e372a803@2ndQuadrant.c! om> <1c283f8e-7f26-d2e9-7860-7c4a38390051@2ndQuadrant.com> Comments: In-reply-to Andrew Dunstan message dated "Mon, 27 Feb 2017 16:22:03 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23416.1488231675.1@sss.pgh.pa.us> Date: Mon, 27 Feb 2017 16:41:15 -0500 Message-ID: <23417.1488231675@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andrew Dunstan writes: > OK, here's the whole series of patches. I've not tested it at all, but this looks generally sane in a quick once-over. A minor quibble is that in 0003, you weren't terribly consistent about argument order --- in some places you have the FmgrInfo argument added before the collation argument, and in some places after. I'd suggest trying to make the argument orders consistent with the fmgr.c support functions. (I'm generally -1 on blindly adding stuff at the end.) regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers