From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Date: Wed, 13 Nov 2024 09:15:08 +0100
Message-ID: <2345099.ElGaqSPkdT@aivenlaptop>
In-Reply-To: <ZzMSJkiNZhimjXWx@paquier.xyz>
References: 
 <3395418.1618352794@sss.pgh.pa.us> <ZywSnWzXskAxSDew@paquier.xyz>
 <ZzMSJkiNZhimjXWx@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart4935095.GXAFRqVoOG"
Content-Transfer-Encoding: 7Bit
Archived-At: 
 <https://www.postgresql.org/message-id/2345099.ElGaqSPkdT%40aivenlaptop>
Precedence: bulk

This is a multi-part message in MIME format.

--nextPart4935095.GXAFRqVoOG
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Le mardi 12 novembre 2024, 09:30:30 heure normale d=E2=80=99Europe centrale=
 Michael=20
Paquier a =C3=A9crit :
> On Thu, Nov 07, 2024 at 10:06:37AM +0900, Michael Paquier wrote:
> > Good point.  Checking all these contrib updates one-by-one is an ant's
> > work, but I'll see if I can get at least some of them done on HEAD.
>=20
> I've begun looking at that a bit, and there are a couple of things
> that we could do better with xml2 in 0005 at least in the context of
> this patch: xpath_nodeset() and xpath_list() don't have any test
> coverage.  That's not an issue directly related to this patch, but
> perhaps we should add something for the functions that we are
> manipulating after this upgrade path at least?  That's one way to
> automatically make sure that these changes work the same way as the
> original.
>=20
> The same argument comes up with lo_oid() in 0006.

Ok, please find attached a new complete patch series including tests for th=
e=20
uncovered functions. Tests pass both before and after the move to SQL-body=
=20
functions.


>=20
> 0004 for pg_freespace is fine regarding that for example as we have
> calls of pg_freespace(regclass) in its sql/.  I've applied it to begin
> with something.

Thank you for this one, removed from the new series.

>=20
> Tomas Vondra has posted a patch for a bug fix with pageinspect, so
> this would create some conflicts noise for him if 0003 was applied
> today, so let's wait a bit:
> https://www.postgresql.org/message-id/3385a58f-5484-49d0-b790-9a198a0bf23=
6@v
> ondra.me

Agreed, let's wait on this one. I did not include it in the series.=20

>=20
> 0001 and 0002 are much larger than the 4 others, and I'm lacking the
> > steam to check them in more details today.

Thanks !

=2D-
Ronan Dunklau

--nextPart4935095.GXAFRqVoOG
Content-Disposition: attachment;
 filename="v4-0001-Add-tests-for-xpath_nodeset-and-xpath_list-functi.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8";
 name="v4-0001-Add-tests-for-xpath_nodeset-and-xpath_list-functi.patch"