From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>, orlovmg@gmail.com,
        pgsql-hackers@postgresql.org
Subject: Re: 64-bit MultiXactOffset vs. 9.3->9.4 upgrade, pg_resetwal,
 "wraparound" msg
In-reply-to: <20260919142122.52.noahmisch@microsoft.com>
References: <20260827231757.78.noahmisch@microsoft.com>
 <8fc26d4c-ff74-4cae-9c3d-db5c4f41d4ec@iki.fi>
 <d35f1255-9232-4fae-a134-bfe2be7bf926@iki.fi>
 <20260917162105.56.noahmisch@microsoft.com>
 <a432f851-deb1-4f24-80cb-9348cb6cd98a@iki.fi>
 <20260919142122.52.noahmisch@microsoft.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 19 Sep 2026 07:21:22 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <235091.1789870332.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 19 Sep 2026 22:12:12 -0400
Message-ID: <235092.1789870332@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/235092.1789870332%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Fri, Sep 18, 2026 at 09:15:38PM +0300, Heikki Linnakangas wrote:
>> From 866999c1251fbbde2f1d9db2799734c7c6e8fe54 Mon Sep 17 00:00:00 2001
>> From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
>> Date: Fri, 18 Sep 2026 20:57:26 +0300
>> Subject: [PATCH 1/1] Check that oldestXID and oldestMulti are consisten=
t at
>> pg_upgrade

> I read this patch.  It looks reasonable, and I expect it provides the in=
tended
> defense.  Thank you.

The BF animals that run cross-version upgrade tests say that this
fails when upgrading from 9.2 [1]:

Performing Consistency Checks
-----------------------------
Checking cluster versions                                     ok
Checking database connection settings                         ok
Checking for unsupported encodings                            ok
Checking names of databases, roles, and tablespaces           ok
Checking database user is the install user                    ok
Checking for prepared transactions                            ok
Checking oldestXID and oldestMultiXid consistency             SQL command =
failed
SELECT datname, datfrozenxid, datminmxid FROM	pg_catalog.pg_database
ERROR:  column "datminmxid" does not exist
LINE 1: SELECT datname, datfrozenxid, datminmxid FROM pg_catalog.pg_...
                                      ^
Failure, exiting

Now, we've dropped support for upgrading from 9.2 in HEAD, but we
have not done so in v19, so I think this needs a fix in v19.
If nothing else works, we could just skip the whole check when source
server is <=3D 9.2.

(I don't think this is worth breaking beta4 release freeze for, but
it should get fixed afterwards.)

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dcrake&dt=3D2=
026-09-19%2014%3A17%3A23