Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kIyWM-00042P-Bc
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 18:20:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kIyWL-0002qa-BF
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 18:20:37 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kIyWL-0002qT-4c
	for pgsql-hackers@lists.postgresql.org; Thu, 17 Sep 2020 18:20:37 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kIyWI-0005qR-SD
	for pgsql-hackers@postgresql.org; Thu, 17 Sep 2020 18:20:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 08HIKSwu235129;
	Thu, 17 Sep 2020 14:20:29 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
In-reply-to: <187727.1600357196@sss.pgh.pa.us>
References: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
 <21042.1589983015@sss.pgh.pa.us>
 <fcbe3e68-19f8-ae3b-cf5a-3e420123826b@2ndquadrant.com>
 <FDCD46CA-C092-4B1D-B19E-314569AA3D88@yesql.se>
 <43461.1600300517@sss.pgh.pa.us>
 <2876D3E9-AD31-4841-869B-CADDBF2EBC66@yesql.se>
 <187727.1600357196@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 17 Sep 2020 11:39:56 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <235127.1600366828.1@sss.pgh.pa.us>
Date: Thu, 17 Sep 2020 14:20:28 -0400
Message-ID: <235128.1600366828@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

I went ahead and added SPI.c, Util.c, and the *kwlist_d.h headers
to the exclusion list.  I then tried to run pgindent in a completely
built-out development directory (not distclean'ed, which is the way
I'd always used it before).  This found a few more exclusions we
need to have if we want to allow for that usage.  Pushed the lot.

We still have to deal with

src/backend/utils/sort/qsort_tuple.c
src/pl/plpgsql/src/plerrcodes.h
src/pl/plpython/spiexceptions.h
src/pl/tcl/pltclerrcodes.h

if we want to be entirely clean about this.

			regards, tom lane