From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Junwang Zhao <zhjwpku@gmail.com>, jian he <jian.universality@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: attndims, typndims still not enforced, but make the value within a sane threshold
In-reply-to: <Zuz6drGzEILysDAO@paquier.xyz>
References: <CACJufxH0RxsxUQnAT2AVG08JFpA3C60L91_cEMM8JQd8P=12ow@mail.gmail.com> <1807434.1726668657@sss.pgh.pa.us> <CACJufxEqJyD0o6t9f1NLp2cgaUeyRzNv+PiDuKnrP1xekHFYyQ@mail.gmail.com> <CACJufxEF9_o_tZeNg+rDV5MfQW6eYTdM9MUcy0Z5-VMWvf-tOw@mail.gmail.com> <CAEG8a3KQyeNvezSS3M3qAHykaDV9uPvTDp9i9+g+GvvDS4W7ug@mail.gmail.com> <Zuz6drGzEILysDAO@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 20 Sep 2024 13:30:46 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2358225.1726807096.1@sss.pgh.pa.us>
Date: Fri, 20 Sep 2024 00:38:16 -0400
Message-ID: <2358226.1726807096@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2358226.1726807096%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Sep 20, 2024 at 11:51:49AM +0800, Junwang Zhao wrote:
>> Should you also bump the catalog version?

> No need to worry about that when sending a patch because committers
> take care of that when merging a patch into the tree.  Doing that in
> each patch submitted just creates more conflicts and work for patch
> authors because they'd need to recolve conflicts each time a
> catversion bump happens.  And that can happen on a daily basis
> sometimes depending on what is committed.

Right.  Sometimes the committer forgets to do that :-(, which is
not great but it's not normally a big problem either.  We've concluded
it's better to err in that direction than impose additional work
on patch submitters.

If you feel concerned about the point, best practice is to include a
mention that catversion bump is needed in your draft commit message.

			regards, tom lane