From: Antonin Houska <ah@cybertec.at>
To: jian he <jian.universality@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: 
 <CACJufxFO-rU4+kQZUPuukPpY7-i1DPgKBsz+O2SK1XxdTivajQ@mail.gmail.com>
References: <202507262156.sb455angijk6@alvherre.pgsql>
 <202510301734.pj4uds3mqxx4@alvherre.pgsql>
 <CACJufxFO-rU4+kQZUPuukPpY7-i1DPgKBsz+O2SK1XxdTivajQ@mail.gmail.com>
Comments: In-reply-to jian he <jian.universality@gmail.com>
   message dated "Sat, 01 Nov 2025 20:42:47 +0800."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Thu, 04 Dec 2025 14:36:12 +0100
Message-ID: <23631.1764855372@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/23631.1764855372%40localhost>
Precedence: bulk

jian he <jian.universality@gmail.com> wrote:

>     if (params.options & CLUOPT_ANALYZE)
>         ereport(ERROR,
>                 errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>                 errmsg("cannot %s multiple tables", "REPACK (ANALYZE)"));
> for this error case, adding a simple test case would be better?

More options should probably be tested, currently we have only very basic
regression test for pg_repackdb. TBD

> + /* Do an analyze, if requested */
> + if (params->options & CLUOPT_ANALYZE)
> + {
> + VacuumParams vac_params =3D {0};
> +
> + vac_params.options |=3D VACOPT_ANALYZE;
> + if (params->options & CLUOPT_VERBOSE)
> + vac_params.options |=3D VACOPT_VERBOSE;
> + analyze_rel(RelationGetRelid(rel), NULL, vac_params,
> + stmt->relation->va_cols, true, NULL);
> + }
>=20
> Looking at the comments in struct VacuumParams, some fields have nonzero =
default
> values =E2=80=94 for example, log_vacuum_min_duration.
> Do we need to explicitly set these fields to their default values?
> (see ExecVacuum)

Perhaps, TBD.

> repack.sgml can also add a
> <refsect1> <title>See Also</title>
> similar to analyze.sgml, vacuum.sgml

ok, added this in v26 (to be posted today):

 <refsect1>
  <title>See Also</title>

  <simplelist type=3D"inline">
   <member><xref linkend=3D"app-pgrepackdb"/></member>
   <member><xref linkend=3D"repack-progress-reporting"/></member>
  </simplelist>
 </refsect1>

(Not added reference to VACUUM FULL and CLUSTER intentionally: whoever uses
REPACK should not need them.

> doc/src/sgml/ref/repack.sgml
> synopsis section missing syntax:
> REPACK USING INDEX

ok, added in v26.

> I am wondering, can we also support
> REPACK opt_utility_option_list USING INDEX

I agree, added that in v26 (Hopefully I haven't broken anything, the syntax=
 is
not trival anymore.)

> MATERIALIZED VIEW:
> create materialized view a_________ as select * from t2;
>=20
> repack (verbose);
> INFO:  repacking "public.a_________" in physical order
> INFO:  "public.a_________": found 0 removable, 10 nonremovable row
> versions in 1 pages
> DETAIL:  0 dead row versions cannot be removed yet.
> CPU: user: 0.00 s, system: 0.00 s, elapsed: 0.00 s.
>=20
> cluster (verbose);
> won't touch materialized view a_________
>=20
> but materialized views don't have bloat, nothing can be removed.
> So here we are waste cycles to repack materialized view?

Answered in https://www.postgresql.org/message-id/3436011762001613%40a7af84=
71-b1b8-48c2-9ff7-631187067407

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com