Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tIsq4-00HFn7-DI
	for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Dec 2024 17:07:00 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tIsq1-001W9T-PB
	for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Dec 2024 17:06:58 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tIsq1-001W9K-FQ
	for pgsql-hackers@lists.postgresql.org; Wed, 04 Dec 2024 17:06:58 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1tIspz-0012tX-Us
	for pgsql-hackers@postgresql.org; Wed, 04 Dec 2024 17:06:58 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4B4H6sKd2366344;
	Wed, 4 Dec 2024 12:06:54 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Nathan Bossart <nathandbossart@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: checksum verification code breaks backups in v16-
In-reply-to: <CA+TgmoaYJVDtB1H4oErZrd6RBzTyp_WG4UgBuKDQMAYTHdYavQ@mail.gmail.com>
References: <CA+TgmoaWmO=V55Cy1brfww9ewjRrZE80ej8ox1iu2p2JhKKu_A@mail.gmail.com> <Z0-FnG0zQ9xlciQP@nathan> <CA+TgmoaV43sD=s6t7ksJ8Ti-o716r4GpVVWGLguEnTtczfFOTg@mail.gmail.com> <Z1B-1-mkWcuG87eg@nathan> <CA+TgmoaYJVDtB1H4oErZrd6RBzTyp_WG4UgBuKDQMAYTHdYavQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 04 Dec 2024 11:43:31 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2366342.1733332014.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 04 Dec 2024 12:06:54 -0500
Message-ID: <2366343.1733332014@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2366343.1733332014%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Dec 4, 2024 at 11:10=E2=80=AFAM Nathan Bossart <nathandbossart@g=
mail.com> wrote:
>> D'oh, sorry.  Even so, I think I'd still vote for back-patching the v17
>> commit that inadvertently fixed this.

> Gotcha. Let's see if anyone else votes.

+1 for a back-patch of 025584a16.  It's made it through a couple of
minor releases now, so I think it's more trustworthy than a
one-liner that you have low confidence in.

			regards, tom lane