Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hMCMO-0004pE-2I
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 May 2019 14:06:52 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hMCML-0006l6-7L
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 May 2019 14:06:49 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hMCMK-0006ky-V6
	for pgsql-hackers@lists.postgresql.org; Thu, 02 May 2019 14:06:48 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hMCMI-0006IU-6e
	for pgsql-hackers@lists.postgresql.org; Thu, 02 May 2019 14:06:48 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x42E6gK1023695
	for <pgsql-hackers@lists.postgresql.org>; Thu, 2 May 2019 10:06:42 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Inconsistent error message wording for REINDEX CONCURRENTLY
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23693.1556806002.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 02 May 2019 10:06:42 -0400
Message-ID: <23694.1556806002@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

In view of the REINDEX-on-pg_class kerfuffle that we're currently
sorting through, I was very glad to see that the concurrent reindex
code doesn't even try:

regression=3D# reindex index concurrently pg_class_oid_index;
psql: ERROR:  concurrent reindex is not supported for catalog relations
regression=3D# reindex table concurrently pg_class; =

psql: ERROR:  concurrent index creation on system catalog tables is not su=
pported

It'd be nice though if those error messages gave the impression of having
been written on the same planet.

(It might be worth comparing wording of other errors-in-common between
what are evidently two completely different code paths...)

			regards, tom lane