From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Andreas Karlsson <andreas@proxel.se>, Stephen Frost <sfrost@snowman.net>,
        Magnus Hagander <magnus@hagander.net>,
        Michael Paquier <michael.paquier@gmail.com>,
        Michael Banck <michael.banck@credativ.de>,
        Peter Geoghegan <pg@heroku.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Reload SSL certificates on SIGHUP
In-reply-to: <cf2ea102-13cd-d51a-8dfe-dfe6b9269e63@2ndquadrant.com>
References: <05677cd3-63b2-b15b-7afd-798e34e607c7@proxel.se>
 <CAB7nPqQU50-UMuFcffmynDbH7_kBx3N-Q3ujL-nM2OF3X8biMA@mail.gmail.com>
 <16e282a4-2573-f629-09e8-e6b0ac615890@2ndquadrant.com>
 <29982.1483412575@sss.pgh.pa.us>
 <CABUevExczKi876tfqH5dY7QcMQu6v3KFBwckozD_OJr0kgVidw@mail.gmail.com>
 <23913.1483458895@sss.pgh.pa.us>
 <CABUevEzWtbL8PqcYXEagCVH_NHYQdMcXqZv4GXEeCW=kkd-J0Q@mail.gmail.com>
 <20995.1483541230@sss.pgh.pa.us>
 <CABUevExdkO3TTLYhc2oQAOWXbnz+mJ8=Tfg+WsB2P6p-_wfYyg@mail.gmail.com>
 <7fca80da-0274-3f36-eb25-d53f940c1977@proxel.se>
 <20170104151429.GP18360@tamriel.snowman.net>
 <1254e97b-a65a-5a63-e938-810507a16d71@proxel.se>
 <22644.1483543579@sss.pgh.pa.us>
 <cf2ea102-13cd-d51a-8dfe-dfe6b9269e63@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Wed, 04 Jan 2017 10:46:28 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23702.1483545440.1@sss.pgh.pa.us>
Date: Wed, 04 Jan 2017 10:57:20 -0500
Message-ID: <23703.1483545440@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 1/4/17 10:26 AM, Tom Lane wrote:
>> How will you know whether there's a pass phrase?

> One could register a password callback that remembers whether it was called.

Hmm ... actually, we don't even need to work that hard.  If we simply
use the callback that's there now, but only during reloads not server
start, then we get the desired behavior.  Reloads will fail because
the wrong passphrase was returned by the callback, and we'll keep the
current SSL state.  It would probably be worth tweaking things to minimize
the amount of log spam that you get from that; but it would work, for
values of "work" similar to what was there before.

I still maintain that the existing solution for passphrases is useless,
but in the interest of removing objections to the current patch, I'll
go make that happen.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers