Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j9xYK-0000ZF-9I for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Mar 2020 20:57:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j9xYI-00050t-TJ for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Mar 2020 20:57:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j9xYI-00050m-Fo for pgsql-hackers@lists.postgresql.org; Thu, 05 Mar 2020 20:57:06 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9xYF-0002ia-UD for pgsql-hackers@lists.postgresql.org; Thu, 05 Mar 2020 20:57:05 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 025Kv10q023706; Thu, 5 Mar 2020 15:57:01 -0500 From: Tom Lane To: Daniel Gustafsson cc: Alvaro Herrera , Postgres hackers Subject: Re: Retiring support for pre-7.3 FK constraint triggers In-reply-to: <09D902BE-20CC-42CA-B8B7-4F92CE9823F6@yesql.se> References: <20200305183656.GA24065@alvherre.pgsql> <09D902BE-20CC-42CA-B8B7-4F92CE9823F6@yesql.se> Comments: In-reply-to Daniel Gustafsson message dated "Thu, 05 Mar 2020 21:37:20 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23704.1583441820.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 05 Mar 2020 15:57:00 -0500 Message-ID: <23705.1583441820@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Daniel Gustafsson writes: > When poking around here I realized that defGetStringList was also left u= nused. > It was added with the logical decoding code but the single callsite has = since > been removed. As it's published in a header we might not want to remove= it, > but I figured I'd bring it up as were talking about removing code. Hm. Kind of inclined to leave it, since somebody will probably need it again someday. regards, tom lane