Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M321543=pgsql-hackers-arkari@postgresql.org>)
	id 1cq3bM-0001OP-FJ
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Mar 2017 20:08:24 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M321543=pgsql-hackers-arkari@postgresql.org>)
	id 1cq3bM-0001PB-1w
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Mar 2017 20:08:24 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cq3Zs-0006hW-6U
	for pgsql-hackers@postgresql.org; Mon, 20 Mar 2017 20:06:52 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1cq3Zl-0006pA-DK
	for pgsql-hackers@postgresql.org; Mon, 20 Mar 2017 20:06:51 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2KK6RL3023724;
	Mon, 20 Mar 2017 16:06:27 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        pgsql-hackers@postgresql.org
Subject: Re: WIP: Faster Expression Processing v4
In-reply-to: <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de>
References: <20161206034955.bh33paeralxbtluv@alap3.anarazel.de>
 <20170209003312.rr7atqepgbrf4xqe@alap3.anarazel.de>
 <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
 <2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
 <20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
 <fcdaa51b-e905-72e0-39dd-5e22f535a253@2ndquadrant.com>
 <20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de>
 <69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi>
 <20170314224706.nxvtapenky6eom3z@alap3.anarazel.de>
 <13062.1489622943@sss.pgh.pa.us>
 <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 19 Mar 2017 23:25:11 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23722.1490040387.1@sss.pgh.pa.us>
Date: Mon, 20 Mar 2017 16:06:27 -0400
Message-ID: <23723.1490040387@sss.pgh.pa.us>
X-Pg-Spam-Score: -1.9 (-)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

... is there a reason why resultnum for EEOP_ASSIGN_* steps is declared
size_t and not just int?  Since it's an array index, and one that
certainly can't be bigger than AttrNumber, that seems rather confusing.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers