public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: deferred writing of two-phase state files adds fragility
Date: Wed, 04 Dec 2024 12:58:43 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZW9iLXu=4tJZ46uakZ0hJZof7mV-PbELx_SoJKDOL-tw@mail.gmail.com>
References: <CA+Tgmob2e542abFO-RspquqVYzpt7X4JeOKMDVXwDEowqzmcOg@mail.gmail.com>
	<[email protected]>
	<CA+TgmoZW9iLXu=4tJZ46uakZ0hJZof7mV-PbELx_SoJKDOL-tw@mail.gmail.com>

Robert Haas <[email protected]> writes:
> On Wed, Dec 4, 2024 at 12:19 PM Tom Lane <[email protected]> wrote:
>> Could we fix it so ROLLBACK TRANSACTION removes the GID from the
>> list of prepared xacts that need to be written out?  Then we'd
>> no longer have a pending requirement to read the broken WAL record.

> That would be nice, but I'm not sure that it's possible. As currently
> implemented, FinishPreparedTransaction() always reads the two-phase
> state data either from the two-phase file or the WAL, whether it's
> committing or rolling back.

I'm not following.  FinishPreparedTransaction is not what's preventing
checkpoints or holding back the VACUUM horizon.  What is doing that
is the in-memory fake PGPROC representing the prepared transaction
(I forget the exact terminology).  I'm suggesting that we could have
some way to nuke one of those without properly cleaning up the
prepared xact.  Maybe it'd need to be invoked via a different command
than ROLLBACK TRANSACTION.

			regards, tom lane

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: deferred writing of two-phase state files adds fragility
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox