From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Amit Langote <amitlangote09@gmail.com>,
        Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_trigger.tgparentid
In-reply-to: <20200227162626.GA1693@alvherre.pgsql>
References: <20200227162626.GA1693@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Thu, 27 Feb 2020 13:26:26 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23763.1582821141.1@sss.pgh.pa.us>
Date: Thu, 27 Feb 2020 11:32:21 -0500
Message-ID: <23764.1582821141@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Thanks both -- pushed.  I also changed regress/sql/triggers to leave
> tables around that have a non-zero tgparentid.  This ensures that the
> pg_upgrade test sees such objects, as well as findoidjoins.

> I refrained from doing the findoidjoins dance itself, though; I got a
> large number of false positives that I think are caused by some pg12-era
> hacking.

Generally I try to update findoidjoins once per release cycle, after
feature freeze.  I don't think it's worth messing with it more often
than that.  But thanks for making sure there'll be data for it to find.

			regards, tom lane