Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs74P-0006LP-Q2 for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 14:56:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hs74O-00007L-LR for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Jul 2019 14:56:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hs74O-00006d-9B for pgsql-hackers@lists.postgresql.org; Mon, 29 Jul 2019 14:56:12 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1hs74M-00038Y-1G for pgsql-hackers@postgresql.org; Mon, 29 Jul 2019 14:56:11 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x6TEu5nd023798; Mon, 29 Jul 2019 10:56:05 -0400 From: Tom Lane To: Michael Paquier cc: Andres Freund , Alvaro Herrera , Rui Hai Jiang , Robert Haas , PostgreSQL Hackers Subject: Re: TopoSort() fix In-reply-to: <20190729015059.GE6959@paquier.xyz> References: <20190726220538.GA17809@alvherre.pgsql> <20190726234835.xqyfukqhhzdiqoih@alap3.anarazel.de> <17997.1564187056@sss.pgh.pa.us> <20190729015059.GE6959@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Mon, 29 Jul 2019 10:50:59 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23796.1564412165.1@sss.pgh.pa.us> Date: Mon, 29 Jul 2019 10:56:05 -0400 Message-ID: <23797.1564412165@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Fri, Jul 26, 2019 at 08:24:16PM -0400, Tom Lane wrote: >> I think this is a sufficiently obvious bug, and a sufficiently >> obvious fix, that we should just fix it and not insist on getting >> a reproducible test case first. I think a test case would soon >> bit-rot anyway, and no longer exercise the problem. >> I certainly do *not* want to wait so long that we miss the >> upcoming minor releases. > +1. Any volunteers? If Robert doesn't weigh in pretty soon, I'll take responsibility for it. regards, tom lane