Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWOAV-0000JD-R4 for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Feb 2023 21:02:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pWOAU-0005XA-Lz for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Feb 2023 21:02:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWOAU-0005Wz-CR for pgsql-hackers@lists.postgresql.org; Sun, 26 Feb 2023 21:02:50 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWOAN-0007xm-9q for pgsql-hackers@lists.postgresql.org; Sun, 26 Feb 2023 21:02:49 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id CD246C0006; Sun, 26 Feb 2023 21:02:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------BTff4BwpNkxhsmpdGDJvXnWF" Message-ID: <237b255b-e063-a82e-66e1-c63a12bf9664@dunslane.net> Date: Sun, 26 Feb 2023 16:02:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: WIN32 pg_import_system_collations Content-Language: en-US To: Peter Eisentraut , =?UTF-8?Q?Juan_Jos=c3=a9_Santamar=c3=ada_Flecha?= Cc: Dmitry Koval , PostgreSQL Hackers References: <0050ec23-34d9-2765-9015-98c04f0e18ac@postgrespro.ru> <639e0abd-ea82-b751-bfba-5166a7a1b304@enterprisedb.com> <20220322010057.w7mzoahyi3jy5dyf@alap3.anarazel.de> <9f1c24f0-9340-8044-94e7-5f5389a53d08@enterprisedb.com> <784b2fa1-2e65-fce1-929c-e9de535b9230@enterprisedb.com> From: Andrew Dunstan In-Reply-To: <784b2fa1-2e65-fce1-929c-e9de535b9230@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------BTff4BwpNkxhsmpdGDJvXnWF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-01-03 Tu 08:48, Peter Eisentraut wrote: > On 09.12.22 13:48, Juan José Santamaría Flecha wrote: >> On Thu, Dec 1, 2022 at 8:46 AM Peter Eisentraut >> > > wrote: >> >> >>     What is the status of this now?  I think the other issue has been >>     addressed? >> >> >> Yes, that's addressed for MSVC builds. I think there are a couple of >> pending issues for MinGW, but those should have their own threads. >> >> The patch had rotten, so PFA a rebased version. > > committed > > Now that I have removed the barrier to testing this in the buildfarm, and added an appropriate locale setting to drongo, we can see that this test fails like this: diff -w -U3 c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/collate.windows.win1252.out c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out --- c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/collate.windows.win1252.out 2023-01-23 04:39:06.755149600 +0000 +++ c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out 2023-02-26 17:32:54.115515200 +0000 @@ -363,16 +363,17 @@ -- to_char SET lc_time TO 'de_DE'; +ERROR: invalid value for parameter "lc_time": "de_DE" SELECT to_char(date '2010-03-01', 'DD TMMON YYYY'); to_char ------------- - 01 MRZ 2010 + 01 MAR 2010 (1 row) SELECT to_char(date '2010-03-01', 'DD TMMON YYYY' COLLATE "de_DE"); to_char ------------- - 01 MRZ 2010 + 01 MAR 2010 (1 row) -- to_date The last of these is especially an issue, as it doesn't even throw an error. See cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------BTff4BwpNkxhsmpdGDJvXnWF Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 2023-01-03 Tu 08:48, Peter Eisentraut wrote:
On 09.12.22 13:48, Juan José Santamaría Flecha wrote:
On Thu, Dec 1, 2022 at 8:46 AM Peter Eisentraut <peter.eisentraut@enterprisedb.com <mailto:peter.eisentraut@enterprisedb.com>> wrote:


    What is the status of this now?  I think the other issue has been
    addressed?


Yes, that's addressed for MSVC builds. I think there are a couple of pending issues for MinGW, but those should have their own threads.

The patch had rotten, so PFA a rebased version.

committed



Now that I have removed the barrier to testing this in the buildfarm, and added an appropriate locale setting to drongo, we can see that this test fails like this:


diff -w -U3 c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/collate.windows.win1252.out c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out
--- c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/collate.windows.win1252.out	2023-01-23 04:39:06.755149600 +0000
+++ c:/prog/bf/root/HEAD/pgsql.build/src/test/regress/results/collate.windows.win1252.out	2023-02-26 17:32:54.115515200 +0000
@@ -363,16 +363,17 @@
 
 -- to_char
 SET lc_time TO 'de_DE';
+ERROR:  invalid value for parameter "lc_time": "de_DE"
 SELECT to_char(date '2010-03-01', 'DD TMMON YYYY');
    to_char
 -------------
- 01 MRZ 2010
+ 01 MAR 2010
 (1 row)
 
 SELECT to_char(date '2010-03-01', 'DD TMMON YYYY' COLLATE "de_DE");
    to_char
 -------------
- 01 MRZ 2010
+ 01 MAR 2010
 (1 row)
 
 -- to_date


The last of these is especially an issue, as it doesn't even throw an error.

See <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2023-02-26%2016%3A56%3A30>


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------BTff4BwpNkxhsmpdGDJvXnWF--