Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h5xcl-0008WC-F2
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Mar 2019 19:08:39 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h5xck-0003rz-7w
	for pgsql-hackers@arkaria.postgresql.org; Mon, 18 Mar 2019 19:08:38 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1h5xcj-0003rs-TT
	for pgsql-hackers@lists.postgresql.org; Mon, 18 Mar 2019 19:08:38 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1h5xch-0005Ah-D9; Mon, 18 Mar 2019 19:08:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2IJ8JHo023866;
	Mon, 18 Mar 2019 15:08:19 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
cc: "Jonathan S. Katz" <jkatz@postgresql.org>,
        Pavel Stehule <pavel.stehule@gmail.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Andres Freund <andres@anarazel.de>,
        Oleg Bartunov <obartunov@postgrespro.ru>,
        Michael Paquier <michael@paquier.xyz>,
        Stas Kelvich <s.kelvich@postgrespro.ru>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        David Steele <david@pgmasters.net>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: jsonpath
In-reply-to: <aae2a342-28ff-1801-1e8e-c80203001078@postgrespro.ru>
References: 
 <CAPpHfdv2bro1224314aRijKJu1bfwEimKr6hExoOaF4sqSDTQA@mail.gmail.com>
 <67128b8b-2d80-9e51-20a8-9ac8e0e2243e@2ndquadrant.com>
 <220821fb-52c0-c277-0959-322c8eef76b2@postgrespro.ru>
 <CAPpHfdsyWVfW7N-T9-H1RjoRZCwQX4w5qRd6SGjbLP=qf_y9iw@mail.gmail.com>
 <CAPpHfdsLuSAGHbn06Qq83=XCDhW8RqFe8tFeq+rYhiNWD=bzFA@mail.gmail.com>
 <CAPpHfduXPikbeCnaVi1d2GQvKJLJcQ_GEe5KrzSPTV1KD0E8+Q@mail.gmail.com>
 <CAFj8pRCkCBQ+ZGJ=1k9LLcyVGQm_RCgmP9zijA3hM9-kjNVSYQ@mail.gmail.com>
 <CAPpHfdtYVPNWu5p6P5A11FXB=0pthUgcRS5W30Zz-WSkT3TQRQ@mail.gmail.com>
 <04981bad-2156-a927-b04c-50ff2c9709ae@postgresql.org>
 <CAPpHfdtYvL+h5W7NYPVf-CWfVbMyqytNu-jV1xUhbPM6rnN8Xg@mail.gmail.com>
 <3247f0b1-ad4a-2d4e-e9b1-1eedc1e7e81a@postgresql.org>
 <CAPpHfdurVc7WQQUNOX2QCVEGnD3h5G0_t5prbcFiofBfqq4V-w@mail.gmail.com>
 <4d103338-2f0b-d304-ee38-420c0fc973f8@postgresql.org>
 <CAPpHfds0OBNnr_uV1Urb1sDTBvyQD7wwX3MO_VgEsXetjrXwZA@mail.gmail.com>
 <36067d03-c085-b3ef-f379-a00aa4bff7e5@postgresql.org>
 <aae2a342-28ff-1801-1e8e-c80203!
 001078@postgrespro.ru>
Comments: In-reply-to Nikita Glukhov <n.gluhov@postgrespro.ru>
	message dated "Mon, 18 Mar 2019 01:57:36 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23864.1552936099.1@sss.pgh.pa.us>
Date: Mon, 18 Mar 2019 15:08:19 -0400
Message-ID: <23865.1552936099@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Just another minor bitch about this patch: jsonpath_scan.l has introduced
a typedef called "keyword".  This is causing pgindent to produce seriously
ugly results in libpq, and probably in other places where that is used as
a field or variable name.  Please rename that typedef to something less
generic.

			regards, tom lane