From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Weird test mixup
In-reply-to: 
 <CA+hUKGK3sCuXMsOKneXOTTFccqsnh5OFSE87+nL5+FK=_z+ppQ@mail.gmail.com>
References: <10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi>
 <2387221.1710454778@sss.pgh.pa.us>
 <CA+hUKGK3sCuXMsOKneXOTTFccqsnh5OFSE87+nL5+FK=_z+ppQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Fri, 15 Mar 2024 11:27:20 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2390105.1710456294.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 14 Mar 2024 18:44:54 -0400
Message-ID: <2390106.1710456294@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2390106.1710456294%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Fri, Mar 15, 2024 at 11:19=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wr=
ote:
>> Do they?  It'd be fairly easy to explain this if these things were
>> being run in "installcheck" style.  I'm not sure about CI, but from
>> memory, the buildfarm does use installcheck for some things.

> Right, as mentioned here:
> https://www.postgresql.org/message-id/flat/CA%2BhUKGJYhcG_o2nwSK6r01eOZJ=
wNWUJUbX%3D%3DAVnW84f-%2B8yamQ%40mail.gmail.com
> That's the "running" test, which is like the old installcheck.

Hmm.  Seems like maybe we need to institute a rule that anything
using injection points has to be marked NO_INSTALLCHECK.  That's
kind of a big hammer though.

			regards, tom lane