From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Tomas Vondra <tomas@vondra.me>, Peter Eisentraut <peter@eisentraut.org>,
        Heikki Linnakangas <hlinnaka@iki.fi>, Japin Li <japinli@hotmail.com>,
        Andres Freund <andres@anarazel.de>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cannot find a working 64-bit integer type on Illumos
In-reply-to: <CA+hUKGLf9CKuAgwKZ4ZBDWvqkSe729D+rXZ-vMpU37-BLso9TQ@mail.gmail.com>
References: <ME3P282MB3166F9D1F71F787929C0C7E7B6312@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> <20240322165305.6zrtxcmzdrywvmsu@awork3.anarazel.de> <ME3P282MB3166D876E9CB83009727A5ECB6312@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> <944094.1711128356@sss.pgh.pa.us> <CA+hUKG+CR05ACFujUbeAd-yM+nNJBSpnyB=q3vbriCJuoSu9Ag@mail.gmail.com> <1229869.1711160593@sss.pgh.pa.us> <CA+hUKG+ZwX-reVMHak3yo-63rrh9AJwEVGW4rCbsoLeSKO54Pg@mail.gmail.com> <7cf1dcb7-306f-4418-bf25-bdc75130db10@eisentraut.org> <CA+hUKGKXEdVSfR6UHXfR3tSQ+TfBNk-ssYmO2F0wCdw7qcx86Q@mail.gmail.com> <d8d68452-7195-41cf-a31b-e660f5ac6e75@iki.fi> <CA+hUKG+rYp-=fTP5kjRmnfPq7YgK-e=J+gJxBvKarkPVzLwQmQ@mail.gmail.com> <0e2cc7af-f0c0-418c-b640-e5eb03eaa6e6@eisentraut.org> <CA+hUKGL7YprY+mkWg-9rVkrzkeC62ppdzyb7KcPp9tcff_5F3Q@mail.gmail.com> <CA+hUKGK7WQX3nTuYbiiGZFcV70CqbmBx4VUOnDy6ZGm1v=qGqQ@mail.gmail.com> <50a4c05e-c43e-4e7e-95d2-4b16493073ed@eisentraut.org> <CA+hUKGJ=6wVNNdv9XAUwNv+hhPCW3FzFEkrr6i5axx090vEmcQ@mail.gmail.com> <227!
 6817.1733293172@sss.pgh.pa.us> <2385947.1733341279@sss.pgh.pa.us> <2397643.1733347237@sss.pgh.pa.us> <CA+hUKGLf9CKuAgwKZ4ZBDWvqkSe729D+rXZ-vMpU37-BLso9TQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 05 Dec 2024 10:44:06 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2401110.1733349005.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 04 Dec 2024 16:50:05 -0500
Message-ID: <2401111.1733349005@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2401111.1733349005%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, Dec 5, 2024 at 10:20=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
>> Another rather serious problem here is that we no longer provide
>> macro PG_INT64_TYPE, which seems rather likely to break applications
>> that were relying on it.  That is part of our external API, we
>> can't just remove it on a whim.

> I had concluded that PG_INT64_TYPE wasn't part of our external API but
> pg_int64 was, based on the comment:

>  /* Define a signed 64-bit integer type for use in client API declaratio=
ns. */
> -typedef PG_INT64_TYPE pg_int64;
> +typedef int64_t pg_int64;

Oh, hmm, maybe so.  OTOH, that typedef breaks the idea of #define'ing
PG_INT64_TYPE as int64_t.  We need this header to be readable without
any prior system headers, so I'm afraid we're all the way back to
making configure derive the name of a 64-bit type.

			regards, tom lane