Subject: Re: Support tab completion for upper character inputs in psql
To: "Tang, Haiying" <tanghy.fnst@cn.fujitsu.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: 
 <a63cbd45e3884cf9b3961c2a6a95dcb7@G08CNEXMBPEKD05.g08.fujitsu.local>
 <457958.1612724100@sss.pgh.pa.us>
 <20210208.170212.1547983279045749071.horikyota.ntt@gmail.com>
 <696766648c7a4266864f843b0e4140dd@G08CNEXMBPEKD05.g08.fujitsu.local>
 <5f225addccc54478a6436b78423f21be@G08CNEXMBPEKD05.g08.fujitsu.local>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <24171b05-cf0f-3073-a73a-57b45b794049@enterprisedb.com>
Date: Mon, 15 Mar 2021 21:20:22 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: 
 <5f225addccc54478a6436b78423f21be@G08CNEXMBPEKD05.g08.fujitsu.local>
Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/24171b05-cf0f-3073-a73a-57b45b794049%40enterprisedb.com>
Precedence: bulk

On 09.02.21 15:48, Tang, Haiying wrote:
> I'm still confused about the APPROPRIATE behavior of tab completion.
> It seems ALTER table/tablespace <name> SET/RESET is already case-insensitive.
> 
> For example
> # alter tablespace dbspace set(e[tab]
> # alter tablespace dbspace set(effective_io_concurrency
> 
> # alter tablespace dbspace set(E[tab]
> # alter tablespace dbspace set(EFFECTIVE_IO_CONCURRENCY

This case completes with a hardcoded list, which is done  
case-insensitively by default.  The cases that complete with a query  
result are not case insensitive right now.  This affects things like

UPDATE T<tab>

as well.  I think your first patch was basically right.  But we need to  
understand that this affects all completions with query results, not  
just the one you wanted to fix.  So you should analyze all the callers  
and explain why the proposed change is appropriate.