From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
cc: Jesper Pedersen <jesper.pedersen@redhat.com>,
        Andres Freund <andres@anarazel.de>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: POC: converting Lists into arrays
In-reply-to: 
 <CAKJS1f_0nc8gk_6bLxQKsFt5os3UCk2MNsNcpva6LJoSoqFm=w@mail.gmail.com>
References: <481.1551390571@sss.pgh.pa.us> <24783.1551568303@sss.pgh.pa.us>
 <20190303043424.itzy3ge52xrkpmpr@alap3.anarazel.de>
 <437.1551637744@sss.pgh.pa.us>
 <CA+TgmoZM4c=v0ifR++i09JFtNtnqTq_HkFmbFjwWqbUJffOLmA@mail.gmail.com>
 <12684.1551723095@sss.pgh.pa.us>
 <20190304190612.vgqqsowzkrh22623@alap3.anarazel.de>
 <26464.1551734920@sss.pgh.pa.us>
 <20190304221101.hdg4vj5fo4eewh3b@alap3.anarazel.de>
 <CAKJS1f-pNfoUJrmU8vgD1WrKLqs9WxOVLQ0RpSWu9h6W9RnypA@mail.gmail.com>
 <20190304235402.nod3gbotk2qtd4nh@alap3.anarazel.de>
 <CAKJS1f-yS201hAAmnxcLb2aeTYNZ_A9R1JNXF6hTVXjhHYN7rQ@mail.gmail.com>
 <1131.1551746172@sss.pgh.pa.us> <14626.1558745627@sss.pgh.pa.us>
 <29297.1558799327@sss.pgh.pa.us>
 <f078ce63-9e04-0f3e-d200-d7ee66279abe@redhat.com>
 <25178.1562006685@sss.pgh.pa.us> <25258.1562023641@sss.pgh.pa.us>
 <CAKJS1f9RUaLrujzpqf15gg_7Wo9-ai7b3-MR=bMH7a-pOWdeZA@mail.gmail.com>
 <2305.1562181615@sss.pgh.pa.us> <29361.1563220190@sss.pgh.pa.us>
 <CAKJS1f_0nc8gk_6bLxQKsFt5os3UCk2MNsNcpva6LJoSoqFm=w@!
 mail.gmail.com>
Comments: In-reply-to David Rowley <david.rowley@2ndquadrant.com>
	message dated "Tue, 16 Jul 2019 14:56:46 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2419.1563246458.1@sss.pgh.pa.us>
Date: Mon, 15 Jul 2019 23:07:38 -0400
Message-ID: <2420.1563246458@sss.pgh.pa.us>
Precedence: bulk

David Rowley <david.rowley@2ndquadrant.com> writes:
> The only thoughts I have so far here are that it's a shame that the
> function got called list_qsort() and not just list_sort().  I don't
> see why callers need to know anything about the sort algorithm that's
> being used.

Meh.  list_qsort() is quicksort only to the extent that qsort()
is quicksort, which in our current implementation is a bit of a
lie already --- and, I believe, it's much more of a lie in some
versions of libc.  I don't really think of either name as promising
anything about the underlying sort algorithm.  What they do share
is an API based on a callback comparison function, and if you are
looking for uses of those, it's a lot easier to grep for "qsort"
than some more-generic term.

			regards, tom lane