From: Nikolay Shaplov <dhyan@nataraj.su>
To: jian he <jian.universality@gmail.com>, pgsql-hackers@lists.postgresql.org
Cc: Peter Smith <smithpb2250@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Yura Sokolov <y.sokolov@postgrespro.ru>, pgsql-hackers@lists.postgresql.org,
 Michael Paquier <michael@paquier.xyz>, Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: [PATCH] New [relation] option engine
Date: Sat, 22 Jun 2024 21:21:08 +0300
Message-ID: <24214970.ouqheUzb2q@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <2726217.uZKlY2gecq@thinkpad-pgpro>
References: 
 <202312081259.2pwkb25emowf@alvherre.pgsql>
 <CACJufxFSkfwQR0tPCgzQQjFw5CNxYsFFi7X_gFuPyRacrqKOPQ@mail.gmail.com>
 <2726217.uZKlY2gecq@thinkpad-pgpro>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2659572.k3LOHGUjKi";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: 
 <https://www.postgresql.org/message-id/24214970.ouqheUzb2q%40thinkpad-pgpro>
Precedence: bulk

--nextPart2659572.k3LOHGUjKi
Content-Type: multipart/mixed; boundary="nextPart2114462.KlZ2vcFHjT";
 protected-headers="v1"
Content-Transfer-Encoding: 7Bit
From: Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: [PATCH] New [relation] option engine
Date: Sat, 22 Jun 2024 21:21:08 +0300
Message-ID: <24214970.ouqheUzb2q@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <2726217.uZKlY2gecq@thinkpad-pgpro>
MIME-Version: 1.0

This is a multi-part message in MIME format.

--nextPart2114462.KlZ2vcFHjT
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

While fixing the patch according to jian he recommendations, I come to a 
conclusion that using void* pointer to a structure is really bad idea. Do not 
know why I ever did it that way from start.
So I fixed it.
Changes of this fix can be seen here: 
https://gitlab.com/dhyannataraj/postgres/-/commit/be4d9e16

The whole patch is attached to this mail.

-- 
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su

--nextPart2114462.KlZ2vcFHjT
Content-Disposition: attachment; filename="v9-0001-New-options-engine.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="unicode-2-0-utf-8";
 name="v9-0001-New-options-engine.patch"