From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
cc: Andy Fan <zhihuifan1213@163.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench error: (setshell) of script 0; execution of meta-command failed
In-reply-to: <2422778.1736521065@sss.pgh.pa.us>
References: <87msfz5qv2.fsf@163.com> <87ikqn5em7.fsf@163.com> <e03fc711-8c48-4fb8-ba94-0862c920c30f@oss.nttdata.com> <b0afe844-84b7-4154-ad2c-6763ff84d876@oss.nttdata.com> <2422778.1736521065@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 10 Jan 2025 09:57:45 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2425049.1736522451.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 10 Jan 2025 10:20:51 -0500
Message-ID: <2425050.1736522451@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2425050.1736522451%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Since legacy-pqsignal is really not supposed to be used by clients
> anymore, maybe we could just adjust it to set SA_RESTART for SIGALRM?
> The other alternatives I can think of amount to re-introducing
> link order dependencies, which would be horrid.

Actually, after re-reading the thread that led to 06843df4a [1],
I think a better idea is to introduce some macro magic to force
frontend clients to use libpgport's version of pqsignal() instead
of the one from libpq.  We mustn't change the real name of libpq's
version, but I think we could get away with that for libpgport.

I'm a bit tied up today, but can look at this over the weekend if
nobody beats me to it.

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/467042.1695766998%40sss.pgh=
.pa.us