Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8Po-0007LP-8p for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 09:13:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gp8Pm-0006eM-Rn for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 09:13:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8Pm-0006eE-KI for pgsql-hackers@lists.postgresql.org; Thu, 31 Jan 2019 09:13:42 +0000 Received: from mx2.mailbox.org ([80.241.60.215]) by magus.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gp8Pj-0001Nu-PN for pgsql-hackers@lists.postgresql.org; Thu, 31 Jan 2019 09:13:41 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id EFE1DA1731; Thu, 31 Jan 2019 10:13:37 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id TOVBhe0plU1X; Thu, 31 Jan 2019 10:13:26 +0100 (CET) From: Antonin Houska To: Michael Paquier cc: Postgres hackers Subject: Re: Unused parameters & co in code In-reply-to: <20190130073317.GP3121@paquier.xyz> References: <20190130073317.GP3121@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Wed, 30 Jan 2019 16:33:17 +0900." MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 31 Jan 2019 10:15:21 +0100 Message-ID: <24267.1548926121@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier wrote: > Hi all, >=20 > I just got a run with CFLAGS with the following options: > -Wunused-function -Wunused-variable -Wunused-const-variable > -Wno-unused-result -Wunused-parameter -Wunused-macros >=20 > And while this generates a lot of noise for callbacks and depending on > the environment used, this is also pointing to things which could be > simplified: This reminds me that I reported some unused arguments too: https://www.postgresql.org/message-id/6702.1473067599@localhost SnapBuildBuildSnapshot() was fixed in commit 6c2003f8a1b, but the other two are still there. --=20 Antonin Houska Cybertec Sch=C3=B6nig & Sch=C3=B6nig GmbH Gr=C3=B6hrm=C3=BChlgasse 26, A-2700 Wiener Neustadt Web: https://www.cybertec-postgresql.com