From: Tom Lane <tgl@sss.pgh.pa.us>
To: Craig Ringer <craig@2ndquadrant.com>
cc: Andres Freund <andres@anarazel.de>, Amit Kapila <amit.kapila16@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Julien Rouhaud <rjuju123@gmail.com>,
        Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Missing errcode() in ereport
In-reply-to: 
 <CAMsr+YFypZJXfT18OrXgZzc0XULw1Eppjwg0sizuBz5Lnb3KJw@mail.gmail.com>
References: 
 <CA+fd4k6N8EjNvZpM8nme+y+05mz-SM8Z_BgkixzkA34R+ej0Kw@mail.gmail.com>
 <CAA4eK1KKmr-Dt-8=C=uoeKk7b6WqOTjjpMt_MXs4eFN1=kAX5w@mail.gmail.com>
 <CAOBaU_bb7FR5cF9RKN42kPHf6pk9CeQ=wTuieJv-t3MroU_q0g@mail.gmail.com>
 <20200317095839.GG2206@paquier.xyz>
 <CAA4eK1+powcFw2EAoVgvH4P3fspAJhxU-VTy0_cR2XpcBZGMAA@mail.gmail.com>
 <32174.1584454158@sss.pgh.pa.us>
 <20200319175902.vjib2tslosw65iyr@alap3.anarazel.de>
 <CAMsr+YFypZJXfT18OrXgZzc0XULw1Eppjwg0sizuBz5Lnb3KJw@mail.gmail.com>
Comments: In-reply-to Craig Ringer <craig@2ndquadrant.com>
	message dated "Mon, 30 Mar 2020 11:54:03 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24280.1585540670.1@sss.pgh.pa.us>
Date: Sun, 29 Mar 2020 23:57:50 -0400
Message-ID: <24281.1585540670@sss.pgh.pa.us>
Precedence: bulk

Craig Ringer <craig@2ndquadrant.com> writes:
> I'd have found it helpful to just have the docs explain clearly how it
> works by chaining the comma operator using functions with ignored return
> values.

Want to write some text?

> That would also help people understand how they can make parts of an
> ereport conditional, e.g. only set errdetail() if there additional info is
> currently available W/O duplicating the rest of the ereport .

There are examples of that in the tree, of course, but maybe an
example in the docs wouldn't be bad either.

			regards, tom lane