X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 2A9EF3A3FD5 for ; Sun, 24 Oct 2004 22:55:25 +0100 (BST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 37783-06 for ; Sun, 24 Oct 2004 21:54:55 +0000 (GMT) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 773493A3FCD for ; Sun, 24 Oct 2004 22:55:22 +0100 (BST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id i9OLtTrM024299; Sun, 24 Oct 2004 17:55:30 -0400 (EDT) To: Andrew Dunstan Cc: "Patches (PostgreSQL)" Subject: Re: [HACKERS] strange result from contrib/seg regression on windows In-reply-to: <41753645.8010301@dunslane.net> References: <4172C96E.6060008@dunslane.net> <10333.1098042565@sss.pgh.pa.us> <41753645.8010301@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Tue, 19 Oct 2004 11:44:05 -0400" Date: Sun, 24 Oct 2004 17:55:29 -0400 Message-ID: <24298.1098654929@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200410/342 X-Sequence-Number: 13567 Andrew Dunstan writes: >> This code shows several other signs of severe brain death, actually, >> like leaking 256 bytes on each call for an error message buffer that it >> doesn't even need :-( I'd recommend ripping the whole thing out and >> replacing with a call to float4in. >> > Patch and alternative regression result file attached (Thanks to Tom for > an assist). Applied. regards, tom lane