Reply-To: jesper.pedersen@redhat.com
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Robert Haas <robertmhaas@gmail.com>,
 David Rowley <david.rowley@2ndquadrant.com>,
 Simon Riggs <simon@2ndquadrant.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>,
 Maksim Milyutin <milyutinma@gmail.com>
References: <20171220212503.aamhlrs425flg47f@alvherre.pgsql>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: Red Hat
Message-ID: <242e9c8d-113e-22e5-05bf-550eb0801f7b@redhat.com>
Date: Thu, 21 Dec 2017 04:58:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171220212503.aamhlrs425flg47f@alvherre.pgsql>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Alvaro,

On 12/20/2017 04:25 PM, Alvaro Herrera wrote:
> I modified the regression test so that a partitioning hierarchy would be
> left behind after the test is run, which is useful to test pg_upgrade
> and pg_dump -- this caught one small bug.  That and some reading of the
> diff resulted in v8, attach.
> 
> On my system, make check-world passes.  However, Thomas Munro's
> automated patch tester seems to have a problem with the pg_upgrade test,
> though I don't know what it is.
> 

Passes check-world here too w/ TAP + cassert.

index.c:

+       values[Anum_pg_index_indparentidx - 1 ] = 
ObjectIdGetDatum(parentIndexOid);

Extra space.

tab-complete.c:

Contains references to DETACH.

create_index.sgml:

I think the new paragraph should mention the naming convention of the 
generated indexes, as they may differ from the index name on the 
partition table.

reindex.sgml:

Missing a note about REINDEX not being supported on the partition index.

Best regards,
  Jesper