From: Tom Lane <tgl@sss.pgh.pa.us>
To: Craig Ringer <craig@2ndquadrant.com>
cc: Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter_e@gmx.net>,
        Magnus Hagander <magnus@hagander.net>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version
 compatibility)
In-reply-to: 
 <CAMsr+YFnhHUnq+fbWshkudwO4WhgeCyodULVpBNdbzzgn8EXMw@mail.gmail.com>
References: 
 <CA+TgmoZ3_xAZ7qdycN4nE44S-6r6-2rkdE1vn_g1RkO91dhBBA@mail.gmail.com>
 <30788.1498672033@sss.pgh.pa.us>
 <CA+TgmoaPt87thVX9QudujN5=Ezr4DGZ77JCxH3WP30eMuD40qQ@mail.gmail.com>
 <CAMsr+YFnhHUnq+fbWshkudwO4WhgeCyodULVpBNdbzzgn8EXMw@mail.gmail.com>
Comments: In-reply-to Craig Ringer <craig@2ndquadrant.com>
	message dated "Thu, 29 Jun 2017 09:44:44 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24356.1498703265.1@sss.pgh.pa.us>
Date: Wed, 28 Jun 2017 22:27:45 -0400
Message-ID: <24357.1498703265@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Craig Ringer <craig@2ndquadrant.com> writes:
> On 29 June 2017 at 03:01, Robert Haas <robertmhaas@gmail.com> wrote:
>> It wouldn't be
>> so bad if unrecognized parameters were just ignored; the client would
>> know from the ServerProtocolVersion (or ParameterStatus) message that
>> server had ignored those options and could respond as it saw fit.

> Yeah. In retrospect it's a pity the key/value pairs don't come with
> some kind of optional/required flag so the client can say "error if
> you don't understand this, it's important" or "I don't care if you
> don't understand this, and I'll notice when you fail to GUC_REPORT it
> back to me". Or some convention like underscore-prefixing for
> optional.

Yeah.  Back in the day I helped design the PNG image format, and one
of the better ideas in it was to make a distinction between critical and
noncritical chunks within a PNG file; that was exactly the idea you're
getting at here.  I agree with the suggestion to drive this off a
parameter-name-based convention.  Having leading underscore indicate
a noncritical parameter sounds fine.

I don't really like any of the ideas that have been mentioned that would
introduce extra network round trips into session startup.  It's expensive
enough already.  The only thing we seem to be really hurting on is the
ability for the client to add extensions to the original StartupMessage,
and this seems like it can fix that.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers