Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSQJI-0005KO-5b for pgsql-hackers@arkaria.postgresql.org; Sun, 19 May 2019 18:13:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hSQJG-0005EW-B9 for pgsql-hackers@arkaria.postgresql.org; Sun, 19 May 2019 18:13:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSQJG-0005EP-2M for pgsql-hackers@lists.postgresql.org; Sun, 19 May 2019 18:13:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSQJE-0006JF-04 for pgsql-hackers@postgresql.org; Sun, 19 May 2019 18:13:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x4JID9Sk002437; Sun, 19 May 2019 14:13:09 -0400 From: Tom Lane To: Piotr Stefaniak cc: Thomas Munro , Pg Hackers , Michael Paquier Subject: Re: Emacs vs pg_indent's weird indentation for function declarations In-reply-to: References: <7659.1548653310@sss.pgh.pa.us> <20190128070842.GF15401@paquier.xyz> <14259.1557895390@sss.pgh.pa.us> <9170.1557955021@sss.pgh.pa.us> <17265.1557955842@sss.pgh.pa.us> <16886.1558104483@sss.pgh.pa.us> <32165.1558286841@sss.pgh.pa.us> Comments: In-reply-to Piotr Stefaniak message dated "Sun, 19 May 2019 17:50:50 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2435.1558289589.1@sss.pgh.pa.us> Date: Sun, 19 May 2019 14:13:09 -0400 Message-ID: <2436.1558289589@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Piotr Stefaniak writes: > On 19/05/2019 19.27, Tom Lane wrote: >> Piotr Stefaniak writes: >>> I think it's safe to assume that upstream can drop support for K&R-style >>> parameters altogether. >> Cool. I already created the switch, but maybe we could have it >> default to -nkr? > Sorry, but GNU indent already uses -kr for something else and I would > like FreeBSD indent have something like that under the same name. > Besides, indent has too many options and this one doesn't look like > particularly desired by anyone. It's possible that someone will complain > some day, but I don't think we should assume that they'll do or that > they're more important than the other users who benefit from your change > being the default behavior and no additional options. Huh. OK, I'll rip the switch back out again. regards, tom lane