Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rD4WR-000ooN-Rp for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Dec 2023 15:18:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rD4WQ-005n2w-6Y for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Dec 2023 15:18:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rD4WP-005n1b-St for pgsql-hackers@lists.postgresql.org; Tue, 12 Dec 2023 15:18:09 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rD4WN-00A3Eq-FP for pgsql-hackers@postgresql.org; Tue, 12 Dec 2023 15:18:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3BCFI0Xo2437427; Tue, 12 Dec 2023 10:18:00 -0500 From: Tom Lane To: "Euler Taveira" cc: "Michael Banck" , "Daniel Gustafsson" , "Tristan Partin" , pgsql-hackers Subject: Re: Add --check option to pgindent In-reply-to: References: <657835bb.500a0220.a88d.2058@mx.google.com> Comments: In-reply-to "Euler Taveira" message dated "Tue, 12 Dec 2023 08:47:34 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2437425.1702394280.1@sss.pgh.pa.us> Date: Tue, 12 Dec 2023 10:18:00 -0500 Message-ID: <2437426.1702394280@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk "Euler Taveira" writes: > When you add exceptions, it starts to complicate the UI. Indeed. It seems like --silent-diff was poorly defined and poorly named, and we need to rethink that option along the way to adding this behavior. The idea that --show-diff and --silent-diff can be used together is just inherently confusing, because they sound like opposites. regards, tom lane