Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eZm7x-0005MG-4T
	for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jan 2018 23:19:17 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eZm7v-0005Mv-Nv
	for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jan 2018 23:19:15 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eZm7v-0005Mj-E6
	for pgsql-hackers@lists.postgresql.org; Thu, 11 Jan 2018 23:19:15 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eZm7t-0000pW-0l
	for pgsql-hackers@postgresql.org; Thu, 11 Jan 2018 23:19:14 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0BNJ8Zc024411;
	Thu, 11 Jan 2018 18:19:08 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Robert Haas <robertmhaas@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>,
        Ildar Musin <i.musin@postgrespro.ru>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: IndexTupleDSize macro seems redundant
In-reply-to: <20180111203250.GR2416@tamriel.snowman.net>
References: <0274288e-9e88-13b6-c61c-7b36928bf221@postgrespro.ru>
 <CAA4eK1+qNuT2iY+gL-yi-Sn-aj=2y7hBD3GFFRrxh6hV-U+X6w@mail.gmail.com>
 <CA+TgmoaBZi-oNU4dK-FBDeqRWijxYKc5Lne2hD7+bn+sXKuT3g@mail.gmail.com>
 <20180111172241.GK2416@tamriel.snowman.net> <8984.1515692863@sss.pgh.pa.us>
 <20180111181713.GN2416@tamriel.snowman.net>
 <20180111203250.GR2416@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Thu, 11 Jan 2018 15:32:50 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24409.1515712748.1@sss.pgh.pa.us>
Date: Thu, 11 Jan 2018 18:19:08 -0500
Message-ID: <24410.1515712748@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Stephen Frost <sfrost@snowman.net> writes:
> Updated (combined) patch attached for review.  I went through and looked
> again to make sure there weren't any cases of making an unaligned
> pointer to a struct and didn't see any, and I added some comments to
> _bt_restore_page().

Looks OK from here.

			regards, tom lane