Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ifnlE-0007su-U7
	for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Dec 2019 16:25:49 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ifnlD-00069g-K9
	for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Dec 2019 16:25:47 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ifnlD-00069Z-BB
	for pgsql-hackers@lists.postgresql.org; Fri, 13 Dec 2019 16:25:47 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ifnlB-000391-4j
	for pgsql-hackers@postgresql.org; Fri, 13 Dec 2019 16:25:46 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xBDGPbi5024415;
	Fri, 13 Dec 2019 11:25:37 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Peter Geoghegan <pg@bowt.ie>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove configure --disable-float4-byval and
 --disable-float8-byval
In-reply-to: 
 <CA+TgmobixQ_GgMi9pYED7v-DQDUZa3YE7ksziuSfs0-r8zj0og@mail.gmail.com>
References: <f3e1e576-2749-bbd7-2d57-3f9dcf75255a@2ndquadrant.com>
 <15316.1572528990@sss.pgh.pa.us>
 <CA+TgmoaCyw26S7wkTshAJKpjP5zfVnLiBSWYYvn5kT7rh3vrZg@mail.gmail.com>
 <CAH2-Wzn1tb8cVoo_E4Tn6CC79ashORQVEteZXMjKnzaz_VmgJQ@mail.gmail.com>
 <15314.1572631210@sss.pgh.pa.us>
 <CAH2-WznBeqqPJgbjg3rHjCt9B2O0B1iXxR9snyjXJTYK44rEJA@mail.gmail.com>
 <CA+TgmoZxtMU-RKtW-Du5RXd33=THxjWNtDj434uNtaAQYAMWOQ@mail.gmail.com>
 <CAH2-Wzm4VDS7oq8Wxe--5zpnD3pv+6ED8jcoB3UGJ36ByavjmA@mail.gmail.com>
 <80f6bf80-8def-1a48-bd91-c656cc0464e1@2ndquadrant.com>
 <CA+TgmobixQ_GgMi9pYED7v-DQDUZa3YE7ksziuSfs0-r8zj0og@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 13 Dec 2019 09:43:39 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24413.1576254337.1@sss.pgh.pa.us>
Date: Fri, 13 Dec 2019 11:25:37 -0500
Message-ID: <24414.1576254337@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> Well, again, I think the proposal here is not get rid of 32-bit
> support, but to have less code that only gets regularly tested on
> 32-bit machines.

That seems like generally a good plan.  But as to the specific idea...

> If we made datums 8 bytes everywhere, we would have
> less such code, and very likely fewer bugs.

... it's not entirely clear to me that it'd be possible to do this
without causing a storm of "cast from pointer to integer of different
size" (and vice versa) warnings on 32-bit machines.  That would be a
deal-breaker independently of any performance considerations, IMO.
So if anyone wants to pursue this, finding a way around that might be
the first thing to look at.

			regards, tom lane