From: Tom Lane <tgl@sss.pgh.pa.us>
To: Paul Ramsey <pramsey@cleverelephant.ca>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allowing extensions to supply operator-/function-specific info
In-reply-to: <B021B357-A20A-4FDD-8657-062A8899C9A1@cleverelephant.ca>
References: <15193.1548028093@sss.pgh.pa.us> <6953.1548297558@sss.pgh.pa.us>
 <6044.1548524131@sss.pgh.pa.us>
 <CA+TgmoYkLjVcbZZ8PYyaCTMYZJCQ8eiod8MSRMDaczjBw=a0bQ@mail.gmail.com>
 <19993.1548697885@sss.pgh.pa.us>
 <CACowWR3jZ4Xo1atU5xTDpEoeeKSw1==sKPhCy3a29HtcE9oQVQ@mail.gmail.com>
 <7671.1551135674@sss.pgh.pa.us>
 <CACowWR3_RyPSYO6a8TVLZ7KnL_rDNh2ywkSTeqFmrAPpP4y6-g@mail.gmail.com>
 <11051.1551139751@sss.pgh.pa.us>
 <CACowWR1ycbLx0t7WwT8uuJnK7E3U+tfzKXBRPaQrgHiCG+hvbA@mail.gmail.com>
 <14747.1551219541@sss.pgh.pa.us>
 <91BAE1F4-7C16-4F87-849F-B01175A8D7D8@cleverelephant.ca>
 <17244.1551226168@sss.pgh.pa.us>
 <74C11775-67A7-48D2-B1E3-24C52A686F86@cleverelephant.ca>
 <15086.1551310830@sss.pgh.pa.us>
 <BBB5F584-5036-4A11-B5FF-D30632EC9E1A@cleverelephant.ca>
 <24277.1551320775@sss.pgh.pa.us>
 <CACowWR3fZRV6fGrH7vsVLqLz0TQJpmzb=wcipqAQBVZSn0sT4g@mail.gmail.com>
 <26156.1551734021@sss.pgh.pa.us>
 <B256FF5D-EF73-4FDE-A50D-9C9E9FB3B159@cleverelephant.ca>
 <31607.1551739943@sss.pgh.pa.us> <48F6F422-4!
 ! F50-4DA6-A6A1-13C4AA1B9D27@cleverelephant.ca>
 <914.1551745379@sss.pgh.pa.us>
 <B021B357-A20A-4FDD-8657-062A8899C9A1@cleverelephant.ca>
Comments: In-reply-to Paul Ramsey <pramsey@cleverelephant.ca>
	message dated "Tue, 05 Mar 2019 11:58:08 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <24445.1551828396.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 05 Mar 2019 18:26:36 -0500
Message-ID: <24446.1551828396@sss.pgh.pa.us>
Precedence: bulk

Paul Ramsey <pramsey@cleverelephant.ca> writes:
> Thanks for the patch, I=E2=80=99ve applied and smoothed and taken your a=
dvice on schema-qualified lookups as well.

Hm, I think your addition of this bit is wrong:

+                    /*
+                    * Arguments were swapped to put the index value on th=
e
+                    * left, so we need the commutated operator for
+                    * the OpExpr
+                    */
+                    if (swapped)
+                    {
+                        oproid =3D get_commutator(oproid);
+                        if (!OidIsValid(oproid))
                         PG_RETURN_POINTER((Node *)NULL);
+                    }

We already did the operator lookup with the argument types in the desired
order, so this is introducing an extra swap.  The only reason it appears
to work, I suspect, is that all your index operators are self-commutators.

			regards, tom lane