From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Tomas Vondra <tomas@vondra.me>, Peter Eisentraut <peter@eisentraut.org>,
        Heikki Linnakangas <hlinnaka@iki.fi>, Japin Li <japinli@hotmail.com>,
        Andres Freund <andres@anarazel.de>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cannot find a working 64-bit integer type on Illumos
In-reply-to: <CA+hUKGLjRYfJGfZofxw4GYdgP-5TYT6KoCtZBOfGrO8z-ap9Hg@mail.gmail.com>
References: <ME3P282MB3166F9D1F71F787929C0C7E7B6312@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> <20240322165305.6zrtxcmzdrywvmsu@awork3.anarazel.de> <ME3P282MB3166D876E9CB83009727A5ECB6312@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM> <944094.1711128356@sss.pgh.pa.us> <CA+hUKG+CR05ACFujUbeAd-yM+nNJBSpnyB=q3vbriCJuoSu9Ag@mail.gmail.com> <1229869.1711160593@sss.pgh.pa.us> <CA+hUKG+ZwX-reVMHak3yo-63rrh9AJwEVGW4rCbsoLeSKO54Pg@mail.gmail.com> <7cf1dcb7-306f-4418-bf25-bdc75130db10@eisentraut.org> <CA+hUKGKXEdVSfR6UHXfR3tSQ+TfBNk-ssYmO2F0wCdw7qcx86Q@mail.gmail.com> <d8d68452-7195-41cf-a31b-e660f5ac6e75@iki.fi> <CA+hUKG+rYp-=fTP5kjRmnfPq7YgK-e=J+gJxBvKarkPVzLwQmQ@mail.gmail.com> <0e2cc7af-f0c0-418c-b640-e5eb03eaa6e6@eisentraut.org> <CA+hUKGL7YprY+mkWg-9rVkrzkeC62ppdzyb7KcPp9tcff_5F3Q@mail.gmail.com> <CA+hUKGK7WQX3nTuYbiiGZFcV70CqbmBx4VUOnDy6ZGm1v=qGqQ@mail.gmail.com> <50a4c05e-c43e-4e7e-95d2-4b16493073ed@eisentraut.org> <CA+hUKGJ=6wVNNdv9XAUwNv+hhPCW3FzFEkrr6i5axx090vEmcQ@mail.gmail.com> <227!
 6817.1733293172@sss.pgh.pa.us> <2385947.1733341279@sss.pgh.pa.us> <CA+hUKGJ6qp-iQQJTLHnXz=Zvjuf-BZSSb=bzCiWGp_JK07vELQ@mail.gmail.com> <CA+hUKG+Ko8qA0bZpOhon3OgyvfHSMu3hByjQ82fvYFaO0UGOWw@mail.gmail.com> <CA+hUKGLjRYfJGfZofxw4GYdgP-5TYT6KoCtZBOfGrO8z-ap9Hg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Thu, 05 Dec 2024 14:06:09 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <2445194.1733369378.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 04 Dec 2024 22:29:38 -0500
Message-ID: <2445195.1733369378@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2445195.1733369378%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, Dec 5, 2024 at 1:59=E2=80=AFPM Thomas Munro <thomas.munro@gmail.=
com> wrote:
>> I was trying to figure out how I missed this, and I think it might be
>> that the meson build scripts didn't port AC_SYS_LARGEFILES.  So if you
>> build on a 32 bit Linux system with meson (like one of CI's tasks, and
>> also build farm animal adder) then I think you finish up with 32 bit
>> off_t and no SIZEOF_OFF_T, because we don't do AC_SYS_LARGEFILES'
>> dance to figure out if this system needs -D_FILE_OFFSET_BITS=3D64 (or
>> other similar macros for AIX, Solaris etc).  I will look into that.

> Ahh, correction, it does define it (or else perl would have
> complained), but it seems that meson magically puts it into the
> compiler command line without being asked.  So it is defined without
> pg_config.h being involved, and thus earlier.  Huh.

That does not seem great.  Compile an extension without the same
CPPFLAGS, you silently get an ABI-incompatible module.  We really
ought to be putting these ABI-critical flags into pg_config.h.
It's especially bad that this works differently between autoconf
and meson builds.

			regards, tom lane