Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1nWTv9-0008J5-5z
	for pgsql-committers@arkaria.postgresql.org; Tue, 22 Mar 2022 02:06:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1nWTv8-00065L-1q
	for pgsql-committers@arkaria.postgresql.org; Tue, 22 Mar 2022 02:06:50 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nWTv7-000658-R7
	for pgsql-committers@lists.postgresql.org; Tue, 22 Mar 2022 02:06:49 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nWTv5-0001Hw-DT; Tue, 22 Mar 2022 02:06:48 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22M26kgm2446638;
	Mon, 21 Mar 2022 22:06:46 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <akapila@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
In-reply-to: <E1nWTkh-000ncF-2O@gemulon.postgresql.org>
References: <E1nWTkh-000ncF-2O@gemulon.postgresql.org>
Comments: In-reply-to Amit Kapila <akapila@postgresql.org>
	message dated "Tue, 22 Mar 2022 01:56:03 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2446636.1647914806.1@sss.pgh.pa.us>
Date: Mon, 21 Mar 2022 22:06:46 -0400
Message-ID: <2446637.1647914806@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: <https://www.postgresql.org/message-id/2446637.1647914806%40sss.pgh.pa.us>
Precedence: bulk

Amit Kapila <akapila@postgresql.org> writes:
> The user can specify LSN by ALTER SUBSCRIPTION ... SKIP (lsn = XXX),
> which allows the apply worker to skip the transaction finished at
> specified LSN. The apply worker skips all data modification changes within
> the transaction.

Hmm ... this seems like a really poor choice of syntax.
I would expect ALTER to be used for changes of persistent
object properties, which surely this is not?

An alternative perhaps could be to invoke the operation
via a function.

			regards, tom lane