public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: [email protected] <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Repeat the condition check twice in function distribute_qual_to_rels
Date: Sun, 03 Nov 2024 14:07:02 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYCPR01MB6093C42081BD8EC36E03478F85502@TYCPR01MB6093.jpnprd01.prod.outlook.com>
References: <TYCPR01MB6093C42081BD8EC36E03478F85502@TYCPR01MB6093.jpnprd01.prod.outlook.com>
"[email protected]" <[email protected]> writes:
> I notice that check the condtion again when after invoked process_equivalence and return failed.
> /* EC rejected it, so set left_ec/right_ec the hard way ... */
> if (restrictinfo->mergeopfamilies) /* EC might have changed this */
> Above the codes, check the condition again when invoked process_equivalence failed,
> but it's already under the positive condition "if (restrictinfo->mergeopfamilies)".
> It's necessary ?
Yes. See commit 8ec5429e2: the restrictinfo might now be
completely different from what it was.
(You could have discovered this for yourself by removing
the test and seeing what happened.)
regards, tom lane
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Repeat the condition check twice in function distribute_qual_to_rels
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox