From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
cc: "Jonathan S. Katz" <jkatz@postgresql.org>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: output columns of \dAo and \dAp
In-reply-to: 
 <CAPpHfdty+_zFZjma-wwnrzLkADymJTgQQ+wVtcqKZ+nz1=J4cQ@mail.gmail.com>
References: <2edc7b27-031f-b2b6-0db2-864241c91cb9@2ndquadrant.com>
 <1698998.1591479248@sss.pgh.pa.us>
 <CAPpHfdvkuAZ4KgE+5U08vDzw81pqzM_abJAT1h3oRem_4w0rMQ@mail.gmail.com>
 <d78c76c2-6e69-078c-6c03-16bbe8b4a5af@postgresql.org>
 <CAPpHfdsFhRqEhjOCSfQj0mmcOyJHCM6T7Hj7UifjUcVUNe5Pxw@mail.gmail.com>
 <CAPpHfdty+_zFZjma-wwnrzLkADymJTgQQ+wVtcqKZ+nz1=J4cQ@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <aekorotkov@gmail.com>
	message dated "Sat, 11 Jul 2020 14:23:33 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2448025.1594497552.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 11 Jul 2020 15:59:12 -0400
Message-ID: <2448026.1594497552@sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <aekorotkov@gmail.com> writes:
> The proposed patch is attached.  This patch is fixes two points:
>  * Adds strategy number and purpose to output of \dAo
>  * Renames "Left/right arg type" columns of \dAp to "Registered left/rig=
ht type"

I think that \dAp should additionally be changed to print the
function via "oid::regprocedure", not just proname.  A possible
compromise, if you think that's too wordy, is to do it that
way for "\dAp+" while printing plain proname for "\dAp".

BTW, isn't this:

                      "  format ('%%s (%%s, %%s)',\n"
                      "    CASE\n"
                      "      WHEN pg_catalog.pg_operator_is_visible(op.oid=
) \n"
                      "      THEN op.oprname::pg_catalog.text \n"
                      "      ELSE o.amopopr::pg_catalog.regoper::pg_catalo=
g.text \n"
                      "    END,\n"
                      "    pg_catalog.format_type(o.amoplefttype, NULL),\n=
"
                      "    pg_catalog.format_type(o.amoprighttype, NULL)\n=
"
                      "  ) AS \"%s\"\n,"

just an extremely painful way to duplicate the results of regoperator?
(You could likely remove the joins to pg_proc and pg_operator altogether
if you relied on regprocedure and regoperator casts.)

> I'm not yet convinced we should change the sort key for \dAo.

After playing with this more, I'm less worried about that than
I was.  I think I was concerned that the operator name would
sort ahead of amopstrategy, but now I see that the op name isn't
part of the sort key at all.

BTW, these queries seem inadequately schema-qualified, notably
the format() calls.

			regards, tom lane