From: =?ISO-8859-1?Q?C=E9dric?= Villemain <cedric@2ndquadrant.com>
To: Peter Eisentraut <peter_e@gmx.net>
Reply-To: cedric@2ndquadrant.com
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org,
 Josh Berkus <josh@agliodbs.com>, Robert Haas <robertmhaas@gmail.com>,
 Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Fri, 11 Oct 2013 12:34:23 +0200
Message-ID: <2449747.BOTx2DZ99o@obelix>
Organization: 2ndQuadrant France
User-Agent: KMail/4.10.5 (Linux/3.10-2-rt-amd64; KDE/4.10.5; x86_64; ; )
In-Reply-To: <1381455444.5264.16.camel@vanquo.pezone.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <52536737.7060006@dunslane.net> <1381455444.5264.16.camel@vanquo.pezone.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2643243.1AiSD8XL48";
 micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--nextPart2643243.1AiSD8XL48
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Le jeudi 10 octobre 2013 21:37:24 Peter Eisentraut a =C3=A9crit :
> On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote:
> > The code has been sitting in HEAD for several months, and I
> > committed on the back branches because it was wanted.
>=20
> New features normally go through a full development cycle including
> extensive beta testing, especially when they contain changes to
> external interfaces.  The fact that the patch author wanted his
> feature released immediately (of course) doesn't warrant a free pass
> in this case, IMO.

What's new feature ?

PGXS break when 19e231b was commited, the patch around this special=20
submake is trying to bugfix that.
See http://www.postgresql.org/message-id/201305281410.32535.cedric@2ndq=
uadrant.com


There are also reports like this one (and thread):
http://www.postgresql.org/message-id/CABRT9RCJ6RvgMXbyebCgYMwBwiOBKO_W6=
zvwrzn75_f+USpQ5g@mail.gmail.com

where you can read that I am not 'the' only guy who want to have this=20=

commited. And believeing this is worth a backpatch as it stands for a=20=

bugfix.

Here also the problem is stated as something to fix.

http://www.postgresql.org/message-id/20130516165318.GF15045@eldon.alvh.=
no-ip.org

That's being said, you are correct about the problem you found and it's=
=20
good to be able to release new version without a bug for OSX.
I'm just sad you didn't get time to voice a bit before Andrew spent too=
=20
much time on that.
--=20
C=C3=A9dric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - D=C3=A9veloppement, Expertise et Formation
--nextPart2643243.1AiSD8XL48
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAABAgAGBQJSV9QzAAoJENsgH0yzVBebgfQIAJU57y2vWYX7Pyh3ydx3HBAJ
bH+QhmmftNE9G2lT7buxgexEII2jw5wEaqWtf14EbAdZ4B8Ja7xbQfEy6LAEHAPE
kHpWRfaR+z2UCbKMidbVtqRrzB6u4ggpd30NJIMHFUZdPCFaai31qiKUwY6vjz2j
nWC7FRAmD+u1o5mjf5SW8vT9X6HNWfm/PQKTbTh9Edd+DNYBUgFWXW9BTE9qSe7W
VEcgs53xRizTAHlXf9BYKK4hRSyaCBRowP5vd67y916Msejhz7375klCTwoqkUT6
yM9D0PjGDF7V1gcS8JWDuk4/Y31Z+pB7zBjRWfgFk99/btnmjc8wms4cC3kwNT8=
=KkKX
-----END PGP SIGNATURE-----

--nextPart2643243.1AiSD8XL48--