Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6AuO-000Riq-TC for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Oct 2025 16:51:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v6AuM-001Us8-BY for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Oct 2025 16:51:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v6AuM-001Urz-2O for pgsql-hackers@lists.postgresql.org; Tue, 07 Oct 2025 16:51:26 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v6AuK-000tNU-2C for pgsql-hackers@postgresql.org; Tue, 07 Oct 2025 16:51:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 597GpKkw2451054; Tue, 7 Oct 2025 12:51:20 -0400 From: Tom Lane To: Matheus Alcantara cc: Joel Jacobson , pgsql-hackers Subject: Re: Optimize LISTEN/NOTIFY In-reply-to: References: <6899c044-4a82-49be-8117-e6f669765f7e@app.fastmail.com> <165530.1752362320@sss.pgh.pa.us> <02a7cd37-e2fc-4212-8b19-f8c239c95fb8@app.fastmail.com> <96f00bf1-cc9d-4520-9d02-9e14e7767c88@app.fastmail.com> <30c2aa7d-dd6c-4b68-a2e4-f217a1a34acf@app.fastmail.com> <0b4d402a-9ac2-4aa8-acf8-8231dbe579ea@app.fastmail.com> <3095599.1758644879@sss.pgh.pa.us> <0dc6a2cc-5216-4dc1-9dd2-430cafc6095b@app.fastmail.com> <52CC167F-763B-4ECA-B0B4-DAB381816828@gmail.com> <9186C6D0-F7A9-482A-9183-89E530B57E36@gmail.com> <1073593.1759423179@sss.pgh.pa.us> <4bd5e6c4-6fa7-44bb-869d-59a32a331fa8@app.fastmail.com> Comments: In-reply-to Matheus Alcantara message dated "Tue, 07 Oct 2025 09:40:51 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2451052.1759855880.1@sss.pgh.pa.us> Date: Tue, 07 Oct 2025 12:51:20 -0400 Message-ID: <2451053.1759855880@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Matheus Alcantara writes: > 7. I'm wondering if we could add some TAP tests for this? async.c seems already moderately well covered by existing tests src/test/regress/sql/async.sql src/test/isolation/specs/async-notify.spec Do we need more? If there's something not covered, can we extend those test cases instead of spinning up a whole new installation for a TAP test? Also, I don't think it's the job of this patch to provide test coverage for dshash. That should be quite well covered already. regards, tom lane