Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbsWi-0006gd-Nn for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 00:28:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pbsWh-0002EO-KX for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 00:28:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbsUh-0005da-26 for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 00:26:23 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbsUd-0002Nr-3j for pgsql-hackers@postgresql.org; Tue, 14 Mar 2023 00:26:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 32E0QHAb2453428; Mon, 13 Mar 2023 20:26:17 -0400 From: Tom Lane To: Jeff Davis cc: pgsql-hackers@postgresql.org Subject: Re: ICU 54 and earlier are too dangerous In-reply-to: References: Comments: In-reply-to Jeff Davis message dated "Mon, 13 Mar 2023 16:39:04 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2453426.1678753577.1@sss.pgh.pa.us> Date: Mon, 13 Mar 2023 20:26:17 -0400 Message-ID: <2453427.1678753577@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Jeff Davis writes: > In ICU 54 and earlier, if ucol_open() is unable to find a matching > locale, it will fall back to the *environment*. That's not great, but ... > Unless someone has a better idea, I think we need to bump the minimum > required ICU version to 55. That would solve the issue in v16 and > later, but those using old versions of ICU and old versions of postgres > would still be vulnerable to these kinds of typos. ... that seems like an overreaction. We know from the buildfarm that there's still a lot of old ICU out there. Is it really improving anybody's life to try to forbid them from using such a version? regards, tom lane