Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXBjL-0004TX-Cb for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jan 2018 20:03:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXBjK-0002fC-WB for pgsql-hackers@arkaria.postgresql.org; Thu, 04 Jan 2018 20:03:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eXBjK-0002f2-Md for pgsql-hackers@lists.postgresql.org; Thu, 04 Jan 2018 20:03:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eXBjI-0000m1-DZ for pgsql-hackers@postgresql.org; Thu, 04 Jan 2018 20:03:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w04K36VH024562; Thu, 4 Jan 2018 15:03:06 -0500 From: Tom Lane To: Maksim Milyutin cc: Andrey Borodin , PostgreSQL mailing lists Subject: Re: [HACKERS] wrong t_bits alignment in pageinspect In-reply-to: References: <9B8647CA-7097-4A8C-9721-6DFAEE93D6AA@yandex-team.ru> Comments: In-reply-to Maksim Milyutin message dated "Thu, 04 Jan 2018 21:06:09 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24560.1515096186.1@sss.pgh.pa.us> Date: Thu, 04 Jan 2018 15:03:06 -0500 Message-ID: <24561.1515096186@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Maksim Milyutin writes: > Attached a new version of patch with regression test. Looks good, pushed. I also removed one error check from tuple_data_split --- there doesn't seem to be a lot of point in checking that bits_str_len is some multiple of 8 when we're about to check that it's equal to a particular multiple of 8. regards, tom lane