From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Noah Misch <noah@leadboat.com>, Nathan Bossart <nathandbossart@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Robert Pang <robertpang@google.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
        pgsql-hackers@postgresql.org
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after a crash
In-reply-to: <Z_ECg-lN2xQbqkLc@paquier.xyz>
References: <Z2L6e1w-xABVTBRR@nathan> <7chjz7zeigbsbt7nim4cj6zryflzcpy2lgenas3yh7cpvwf3gb@m6cwqzlvfd6q> <Z2Oy1Z2nMVmTM5L5@paquier.xyz> <20250306193013.36.nmisch@google.com> <Z8n7HopB0bb4_j19@nathan> <Z853yPDh1xNWssD_@paquier.xyz> <20250311205749.a8.nmisch@google.com> <Z9DZY8PVgXI3-b5j@paquier.xyz> <20250312012315.fd.nmisch@google.com> <20250403002900.5d.nmisch@google.com> <Z_ECg-lN2xQbqkLc@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sat, 05 Apr 2025 19:14:27 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2461390.1743865633.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 05 Apr 2025 11:07:13 -0400
Message-ID: <2461391.1743865633@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2461391.1743865633%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Apr 02, 2025 at 05:29:00PM -0700, Noah Misch wrote:
>> Here it is.  Making it fail three times took looping 1383s, 5841s, and =
2594s.
>> Hence, it couldn't be expected to catch the regression before commit, b=
ut it
>> would have made sufficient buildfarm and CI noise in the day after comm=
it.

> Hmm.  Not much of a fan of the addition of a test that has less than
> 1% of reproducibility for the problem, even if it's good to see that
> this can be made portable to run down to v13.

Yeah, it's good to have a test but I doubt we should commit it.
Too many buildfarm cycles will be expended for too little result.

			regards, tom lane