Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gK3Kz-00078i-RW
	for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Nov 2018 15:32:17 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gK3Kx-0006hI-Jv
	for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Nov 2018 15:32:15 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gK3Kx-0006gH-8t
	for pgsql-hackers@lists.postgresql.org; Tue, 06 Nov 2018 15:32:15 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gK3Ku-0004Me-BR
	for pgsql-hackers@postgresql.org; Tue, 06 Nov 2018 15:32:13 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wA6FW20B024644;
	Tue, 6 Nov 2018 10:32:02 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Jesper Pedersen <jesper.pedersen@redhat.com>,
        Magnus Hagander <magnus@hagander.net>, Oskari Saarenmaa <os@ohmu.fi>,
        Pg Hackers <pgsql-hackers@postgresql.org>,
        Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
In-reply-to: 
 <CAEepm=1GmuQ---ZDmmDzU6uS0QF==PeD1N-XLY7pSfndxTpnfQ@mail.gmail.com>
References: <20181105155918.jg36uj4rtnxwqtzt@alvherre.pgsql>
 <1791.1541438632@sss.pgh.pa.us>
 <CAEepm=1GmuQ---ZDmmDzU6uS0QF==PeD1N-XLY7pSfndxTpnfQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@enterprisedb.com>
	message dated "Tue, 06 Nov 2018 15:10:42 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24642.1541518322.1@sss.pgh.pa.us>
Date: Tue, 06 Nov 2018 10:32:02 -0500
Message-ID: <24643.1541518322@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Tue, Nov 6, 2018 at 6:23 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What I suggest is that we *not* try to make this a completely transparent
>> substitute.  Instead, make the functions exported by src/port/ be
>> "pg_pread" and "pg_pwrite", ...

> OK.  But since we're using this from both fd.c and xlog.c, I put that
> into src/include/port.h.

LGTM.  I didn't bother to run an actual test cycle, since it's not
materially different from the previous version as far as portability
is concerned.

			regards, tom lane